Skip to content

ci-operator/config/openshift/cluster-authentication-operator: Generic e2e-aws -> e2e for 4.6+ #10180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 30, 2020
Merged

ci-operator/config/openshift/cluster-authentication-operator: Generic e2e-aws -> e2e for 4.6+ #10180

openshift-merge-robot merged 1 commit into from
Jul 30, 2020

Conversation

@wking
Copy link
Member

@wking wking commented Jul 10, 2020

Following the pattern from e7bb102 (#10152), the "e2e-aws" -> "e2e" change declares the router presubmits to be platform-agnostic.

The AWS -> GCP change takes advantage of the platform-agnosticism to shift CI load from AWS (where we're currently pegging Boskos lease capacity) to GCP (where we have some spare lease capacity).

Procedure docs in flight with #10166.

@wking wking force-pushed the platform-agnostic-auth-presubmits branch from 908899e to fa07a3e Compare July 10, 2020 16:54
@deads2k
Copy link
Contributor

deads2k commented Jul 10, 2020

I have absolutely no idea whether or not this is correct.

@wking wking force-pushed the platform-agnostic-auth-presubmits branch from fa07a3e to 5144b05 Compare July 10, 2020 17:26
@wking
Copy link
Member Author

wking commented Jul 10, 2020

I have absolutely no idea whether or not this is correct.

Rehearsals should show the new generically-named jobs running on GCP. Looking at them, I saw I'd missed some generic naming on 4.7 and have just pushed fa07a3e440 -> 5144b05141 to fix that.

@wking
ci-operator/config/openshift/cluster-authentication-operator: Generic…
6beb34e 
… e2e-aws -> e2e for 4.6+

Following the pattern from e7bb102
(ci-operator/config/openshift/cluster-version-operator: Generic
e2e-gcp -> e2e for 4.4+, 2020-07-09, openshift#10152), the "e2e-aws" -> "e2e"
change declares the router presubmits to be platform-agnostic
(although David has specifically requested to be kept off Azure based
on CI-success stability concerns).

The AWS -> GCP change takes advantage of the platform-agnosticism to
shift CI load from AWS (where we're currently pegging Boskos lease
capacity) to GCP (where we have some spare lease capacity).
@wking wking force-pushed the platform-agnostic-auth-presubmits branch from 5144b05 to 6beb34e Compare July 17, 2020 00:49
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 17, 2020

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-authentication-operator/release-4.7/e2e-aws fa07a3e440b12672abc393851e99fd0de9bf70fa link /test pj-rehearse
ci/rehearse/openshift/cluster-authentication-operator/release-4.6/e2e-upgrade 6beb34e link /test pj-rehearse
ci/rehearse/openshift/cluster-authentication-operator/master/e2e-console-login 6beb34e link /test pj-rehearse
ci/rehearse/openshift/cluster-authentication-operator/release-4.7/e2e-upgrade 6beb34e link /test pj-rehearse
ci/rehearse/openshift/cluster-authentication-operator/release-4.7/e2e-operator-encryption 6beb34e link /test pj-rehearse
ci/rehearse/openshift/cluster-authentication-operator/release-4.7/e2e-operator 6beb34e link /test pj-rehearse
ci/rehearse/openshift/cluster-authentication-operator/release-4.7/e2e 6beb34e link /test pj-rehearse
ci/rehearse/openshift/cluster-authentication-operator/master/e2e-upgrade 6beb34e link /test pj-rehearse
ci/rehearse/openshift/cluster-authentication-operator/release-4.7/e2e-console-login 6beb34e link /test pj-rehearse
ci/prow/pj-rehearse 6beb34e link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member Author

wking commented Jul 20, 2020

4.7 looks sad, with rehearsals like 4.7-e2e-upgrade dying on:


level=fatal msg="failed to initialize the cluster: Multiple errors are preventing progress:\n* Could not update prometheusrule \"openshift-cloud-credential-operator/cloud-credential-operator-alerts\" (509 of 600): the server is reporting an internal error\n* Could not update prometheusrule \"openshift-cluster-machine-approver/machineapprover-rules\" (525 of 600): the server is reporting an internal error\n* Could not update prometheusrule \"openshift-cluster-samples-operator/samples-operator-alerts\" (308 of 600): the server is reporting an internal error\n* Could not update prometheusrule \"openshift-cluster-version/cluster-version-operator\" (9 of 600): the server is reporting an internal error\n* Could not update prometheusrule \"openshift-machine-api/cluster-autoscaler-operator-rules\" (223 of 600): the server is reporting an internal error\n* Could not update prometheusrule \"openshift-marketplace/marketplace-alert-rules\" (458 of 600): the server is reporting an internal error\n* Could not update route \"openshift-console/downloads\" (393 of 600): the server is down or not responding"

But it's using GCP. And the 4.6 rehearsals are looking happier, and also using GCP. Only 4.6 rehearsal failure was an install-time flake:

level=error msg="Error: Error creating service account: Post \"https://iam.googleapis.com/v1/projects/openshift-gce-devel-ci/serviceAccounts?alt=json&prettyPrint=false\": net/http: request canceled (Client.Timeout exceeded while awaiting headers)"
level=error

in 4.6-e2e-upgrade. @deads2k , is that enough evidence for correctness of this change? Or is there something more you're looking for?

@smarterclayton
Copy link
Contributor

smarterclayton commented Jul 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit 563f9cd into openshift:master Jul 30, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 30, 2020

@wking: Updated the following 9 configmaps:

  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cluster-authentication-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-master-presubmits.yaml
  • job-config-4.6 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cluster-authentication-operator-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-4.6-presubmits.yaml
  • job-config-4.7 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cluster-authentication-operator-release-4.7-presubmits.yaml using file ci-operator/jobs/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-4.7-presubmits.yaml
  • job-config-4.7 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-authentication-operator-release-4.7-presubmits.yaml using file ci-operator/jobs/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-4.7-presubmits.yaml
  • job-config-4.6 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-authentication-operator-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-4.6-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-authentication-operator-master.yaml using file ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-master.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-authentication-operator-release-4.6.yaml using file ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-4.6.yaml
  • ci-operator-4.7-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-authentication-operator-release-4.7.yaml using file ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-release-4.7.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-authentication-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-master-presubmits.yaml
Details

In response to this:

Following the pattern from e7bb102 (#10152), the "e2e-aws" -> "e2e" change declares the router presubmits to be platform-agnostic.

The AWS -> GCP change takes advantage of the platform-agnosticism to shift CI load from AWS (where we're currently pegging Boskos lease capacity) to GCP (where we have some spare lease capacity).

Procedure docs in flight with #10166.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the platform-agnostic-auth-presubmits branch July 30, 2020 18:23
@wking wking mentioned this pull request Aug 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wking @deads2k @openshift-ci-robot @smarterclayton @openshift-merge-robot