-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Switch e2e and e2e-upgrade jobs to gcp in-keeping with current norms #10618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@marun: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marun, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@marun: Updated the following 3 configmaps:
DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| container: | ||
| from: test-bin | ||
| - as: e2e-aws | ||
| - as: e2e-gcp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The platform being targeted seems like a useful detail to expose. prow confusion is temporary, and how often do we really pivot jobs to different platforms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The platform being targeted seems like a useful detail to expose.
It's still available if you need it. I don't see why it needs top billing in the job names on preflights for platform-agnostic repositories.
prow confusion is temporary, and how often do we really pivot jobs to different platforms?
This would be the fourth or fifth repo to pivot in the past month. By declaring yourself platform agnostic with a generic job name, you create a larger pool of reschedulable jobs that can be shifted to mitigate future capacity issues.
No description provided.