Skip to content

Conversation

@marun
Copy link
Contributor

@marun marun commented Jul 31, 2020

No description provided.

@marun marun requested a review from sttts July 31, 2020 18:35
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 31, 2020

@marun: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/oauth-server/master/e2e-gcp-serial c931ab78c5fdbb765d13e22da539cd5220d28ce0 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts
Copy link
Contributor

sttts commented Jul 31, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2020
@openshift-merge-robot openshift-merge-robot merged commit 94c4f82 into openshift:master Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

@marun: Updated the following 3 configmaps:

  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-oauth-server-master-presubmits.yaml using file ci-operator/jobs/openshift/oauth-server/openshift-oauth-server-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-oauth-server-master.yaml using file ci-operator/config/openshift/oauth-server/openshift-oauth-server-master.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-oauth-server-master-presubmits.yaml using file ci-operator/jobs/openshift/oauth-server/openshift-oauth-server-master-presubmits.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

container:
from: test-bin
- as: e2e-aws
- as: e2e-gcp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are platform-agnostic, can we name these e2e? Then you can pivot the backing platform as needed without having Prow get confused about the jobs being renamed. Docs. Examples: #10152, #10179, #10180, #10377.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The platform being targeted seems like a useful detail to expose. prow confusion is temporary, and how often do we really pivot jobs to different platforms?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The platform being targeted seems like a useful detail to expose.

It's still available if you need it. I don't see why it needs top billing in the job names on preflights for platform-agnostic repositories.

prow confusion is temporary, and how often do we really pivot jobs to different platforms?

This would be the fourth or fifth repo to pivot in the past month. By declaring yourself platform agnostic with a generic job name, you create a larger pool of reschedulable jobs that can be shifted to mitigate future capacity issues.

@marun marun deleted the oauth-to-gcp branch February 1, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants