Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Aug 27, 2020

Add all of openshift/cluster-api-provider-*.

@wking wking force-pushed the cluster-api-providers-are-platform-specific branch from 2416aff to 8ebdc1a Compare August 27, 2020 17:28
@alvaroaleman
Copy link
Contributor

@wking can you put this script into a subdir and make yourself owner of that?

@wking
Copy link
Member Author

wking commented Aug 27, 2020

sure. I'd still have to flag someone down for a LGTM, though. Will file a separate PR.

wking added a commit to wking/openshift-release that referenced this pull request Aug 28, 2020
Alvaro requested I move this into a subdirectory so I can be the
approver [1], and not have to pester the rest of the test-platform
folks for approval.

[1]: openshift#11354 (comment)
…ders are platform specific

Add all of openshift/cluster-api-provider-*.
@wking wking force-pushed the cluster-api-providers-are-platform-specific branch from 8ebdc1a to 3b5bc23 Compare August 31, 2020 23:42
@wking wking changed the title hack/step-jobs-by-platform: Cluster API providers are platform specific ci-operator/platform-balance/step-jobs-by-platform: Cluster API providers are platform specific Aug 31, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
@wking
Copy link
Member Author

wking commented Aug 31, 2020

Rebased around #11380 with 8ebdc1a320 -> 3b5bc23.

@bparees
Copy link
Contributor

bparees commented Aug 31, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 61cd391 into openshift:master Aug 31, 2020
@wking wking deleted the cluster-api-providers-are-platform-specific branch August 31, 2020 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants