Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Aug 28, 2020

@alvaroaleman requested I move this into a subdirectory so I can be the approver, and not have to pester the rest of the test-platform folks for approval.

/assign @alvaroaleman

Copy link
Contributor

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alvaroaleman
Copy link
Contributor

/hold
@wking conflicts :/

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 28, 2020
Alvaro requested I move this into a subdirectory so I can be the
approver [1], and not have to pester the rest of the test-platform
folks for approval.

[1]: openshift#11354 (comment)
@wking wking force-pushed the platform-balance-subdir branch from e4a61c8 to f0c3976 Compare August 28, 2020 21:03
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@wking
Copy link
Member Author

wking commented Aug 28, 2020

/hold cancel

Rebased on master with e4a61c83fe -> f0c3976.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants