ci-operator/config/openshift/cluster-etcd-operator: Generic e2e for 4.6+ #11370
Conversation
Following the pattern from e7bb102 (ci-operator/config/openshift/cluster-version-operator: Generic e2e-gcp -> e2e for 4.4+, 2020-07-09, openshift#10152), this commit is using platform-agnostic names for the required tests. The role of platform-agnostic tests is discussed in 4212d7d (ci-operator/README: Discuss platform job rebalancing, 2020-07-09, openshift#10166). The platform-specific jobs are retained, in case folks want to ask for them explicitly with '/test e2e-aws', etc. while performing any platform-specific tuning logic. Making them on-demand reduces our load in platforms where we are near capacity. With this change: * We grow a new, platform-agnostic e2e that is always_run=true and optional=false. * e2e-gcp-upgrade becomes the platform-agnostic e2e-upgrade. * e2e-aws-operator becomes the platform-agnostic e2e-operator. * e2e-aws-disruptive becomes the platform-agnostic e2e-disruptive. * e2e-aws and e2e-gcp become always_run=false and optional=true. * e2e-azure and e2e-metal-ipi become always_run=false (they were already optional=true). I've also ordered the configs to place the platform-agnostic stuff first and shunt the platform-specific stuff towards the end. Generated by manually changing `ci-operator/config/...`, running: $ make update and tuning the configurable [1] always_run and optional. [1]: https://github.com/openshift/ci-tools/blob/7fb6fd8b3802e47162442c9a5e10807952ba12eb/GENERATOR.md#hand-edited-prow-configuration
wking
force-pushed
the
optional-platform-specific-etcd-operator
branch
from
c0d07c6 to
151d520
Compare
| workflow: openshift-e2e-aws-loki | ||
| - as: e2e-gcp-upgrade | ||
| cluster_profile: gcp | ||
| workflow: openshift-e2e-gcp-loki |
There was a problem hiding this comment.
I picked GCP to back the new e2e. Let me know if you prefer AWS.
|
e2e: /retest |
|
/test pj-rehearse |
wking
force-pushed
the
optional-platform-specific-etcd-operator
branch
from
560eefb to
151d520
Compare
|
/retest |
|
/test all |
|
/approve thank you for this! |
openshift-ci-robot
added
the
approved
|
/test all |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I think this plan is sound the failures with rehearse are more indicative of current CI health than etcd-operator. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hexfusion, ironcladlou, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: Updated the following 9 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Following the pattern from e7bb102 (#10152), this commit is using platform-agnostic names for the required tests. The role of platform-agnostic tests is discussed in 4212d7d (#10166).
The platform-specific jobs are retained, in case folks want to ask for them explicitly with
/test e2e-aws, etc. while performing any platform-specific tuning logic. Making them on-demand reduces our load in platforms where we are near capacity.With this change:
I've also ordered the configs to place the platform-agnostic stuff first and shunt the platform-specific stuff towards the end.
Generated by manually changing
ci-operator/config/..., running:$ make updateand tuning the configurable always_run and optional.