-
Notifications
You must be signed in to change notification settings - Fork 2.1k
NO-ISSUE: use latest release payload for the integration tests #54542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: use latest release payload for the integration tests #54542
Conversation
|
@andfasano: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack Note that currently the integration tests are broken for another reason (lack of origin 4.17 release image) |
|
@andfasano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-installer-master-agent-integration-tests |
|
@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I just wish there was a way to avoid the increased running time because of the dependency on the installer images as a multi-step test:
- Before:
Test started today at 5:19 PM failed after 24m14s - After:
Test started today at 6:40 PM failed after 1h7m40s.
/hold
Feel free to unhold if you're happy with that.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Previously the integration tests referenced an (older) origin release payload, instead of the (up-to-date) ephemereal one assembled for the PR under test by the ci-operator. Even though in most of the cases it worked fine, it wasn't optimal and did not allow to test properly the agent commands, especially when a feature is spawning across differente release payload images (and this happens for the agent commands). So, despite the delayed start time (which I'm not sure it could be avoided in any case), the reference to the ephemeral release will improve in the quality and robustness (and moreover correctness) of the integration tests. /hold cancel |
|
@andfasano: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Required by openshift/installer#8749