Skip to content

Conversation

@andfasano
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 18, 2024
@openshift-ci-robot
Copy link
Contributor

@andfasano: This pull request explicitly references no jira issue.

Details

In response to this:

Required by openshift/installer#8749

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano
Copy link
Contributor Author

cc @patrickdillon @r4f4

@openshift-ci openshift-ci bot requested review from barbacbd and bfournie July 18, 2024 16:22
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@andfasano: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-agent-integration-tests openshift/installer presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@andfasano
Copy link
Contributor Author

/pj-rehearse ack

Note that currently the integration tests are broken for another reason (lack of origin 4.17 release image)

@openshift-ci-robot
Copy link
Contributor

@andfasano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 18, 2024
@r4f4
Copy link
Contributor

r4f4 commented Jul 18, 2024

/pj-rehearse pull-ci-openshift-installer-master-agent-integration-tests

@openshift-ci-robot
Copy link
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I just wish there was a way to avoid the increased running time because of the dependency on the installer images as a multi-step test:

  • Before: Test started today at 5:19 PM failed after 24m14s
  • After: Test started today at 6:40 PM failed after 1h7m40s.

/hold
Feel free to unhold if you're happy with that.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andfasano
Copy link
Contributor Author

/lgtm

I just wish there was a way to avoid the increased running time because of the dependency on the installer images as a multi-step test:

* [Before](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/8749/pull-ci-openshift-installer-master-agent-integration-tests/1813956464427929600): `Test started today at 5:19 PM failed after 24m14s`

* [After](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/54542/rehearse-54542-pull-ci-openshift-installer-master-agent-integration-tests/1813976804755509248): `Test started today at 6:40 PM failed after 1h7m40s.`

/hold Feel free to unhold if you're happy with that.

Previously the integration tests referenced an (older) origin release payload, instead of the (up-to-date) ephemereal one assembled for the PR under test by the ci-operator. Even though in most of the cases it worked fine, it wasn't optimal and did not allow to test properly the agent commands, especially when a feature is spawning across differente release payload images (and this happens for the agent commands). So, despite the delayed start time (which I'm not sure it could be avoided in any case), the reference to the ephemeral release will improve in the quality and robustness (and moreover correctness) of the integration tests.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

@andfasano: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/master/agent-integration-tests f5f4858 link unknown /pj-rehearse pull-ci-openshift-installer-master-agent-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6cf8308 into openshift:master Jul 19, 2024
aviavraham pushed a commit to aviavraham/openshift_release that referenced this pull request Jul 22, 2024
aviavraham pushed a commit to aviavraham/openshift_release that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants