-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Mount vsphere credentials for hive e2e #64095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/assign @rvanderp3 |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack |
|
@dlom: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@dlom: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I think Joe/Rich's lgtm might be enough to merge this. If not, I'll stamp it once one or both of them have acked. But it makes sense to me, assuming this is the correct one of several possible sets of vcenter creds I see floating around the release repo. |
|
This is the path that the |
|
Alright, let's get this moving. If it's wrong, it ain't gonna break the job worse. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dlom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
xref: HIVE-2270
see also: openshift/hive#2541
slack thread: https://redhat-internal.slack.com/archives/CH06KMDRV/p1745262442030989