Skip to content

Conversation

@dlom
Copy link
Contributor

@dlom dlom commented Apr 21, 2025

@dlom
Copy link
Contributor Author

dlom commented Apr 21, 2025

/assign @rvanderp3
/cc @jcpowermac
/cc @2uasimojo

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dlom: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hive-master-e2e-vsphere openshift/hive presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dlom
Copy link
Contributor Author

dlom commented Apr 21, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@dlom: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 21, 2025

@dlom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@2uasimojo
Copy link
Member

I think Joe/Rich's lgtm might be enough to merge this. If not, I'll stamp it once one or both of them have acked. But it makes sense to me, assuming this is the correct one of several possible sets of vcenter creds I see floating around the release repo.

@dlom
Copy link
Contributor Author

dlom commented Apr 21, 2025

This is the path that the GOVC_TLS_CA_CERTS env var is pointing to, so theoretically it should be all that's required

@2uasimojo
Copy link
Member

Alright, let's get this moving. If it's wrong, it ain't gonna break the job worse.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 334da16 into openshift:master Apr 22, 2025
13 checks passed
jinyunma pushed a commit to jinyunma/release that referenced this pull request Apr 27, 2025
ctartici pushed a commit to ctartici/release_ctartici that referenced this pull request Apr 28, 2025
mehabhalodiya pushed a commit to mehabhalodiya/release that referenced this pull request Apr 29, 2025
Neilhamza pushed a commit to Neilhamza/release that referenced this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants