Core 1079 port adoption and interest pages to ts #2763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
commented
Aug 6, 2025
| const {adoptionUrl} = useSalesforceContext(); | ||
| const validatePage = React.useCallback( | ||
| (page) => { | ||
| if (page === 1 && position === 'Student') { |
There was a problem hiding this comment.
Student processing can't get here
RoyEJohnson
commented
Aug 6, 2025
| }, []); | ||
| const doSubmit = React.useCallback( | ||
| (form) => { | ||
| if (selectedBooksRef.current?.length > 0) { |
There was a problem hiding this comment.
Can't get here with no selected books.
RoyEJohnson
commented
Aug 6, 2025
| return ( | ||
| <React.Fragment> | ||
| <FormTarget submitting={submitting} /> | ||
| <FormTarget /> |
There was a problem hiding this comment.
submitting isn't handled with a parameter anymore.
RoyEJohnson
commented
Aug 6, 2025
| value: 'Conference', | ||
| label: formatMessage({id: 'interest.option.Conference'}) | ||
| }, | ||
| {value: 'Email', label: formatMessage({id: 'interest.option.Email'})}, |
There was a problem hiding this comment.
Interesting choice by prettier
RoyEJohnson
commented
Aug 6, 2025
| // fireEvent(options[0], new MouseEvent('mouseenter', { | ||
| // bubbles: true | ||
| // })); | ||
| const i = options.findIndex((o) => o.getAttribute('aria-selected') === 'true'); |
There was a problem hiding this comment.
This test was intermittently failing, so I rewrote it. Seems to be happier.
RoyEJohnson
commented
Aug 6, 2025
| <body> | ||
| <section class="block-heading"> |
There was a problem hiding this comment.
Test coverage in the general page
RoyEJohnson
commented
Aug 6, 2025
| ); | ||
|
|
||
| const buttons = screen.getAllByRole('checkbox'); | ||
| const label = buttons[0].getAttribute('aria-label'); |
There was a problem hiding this comment.
A little Partner page functionality that didn't have test coverage: filter remover
jivey
approved these changes
Aug 8, 2025
RoyEJohnson
deleted the
core-1079-port-adoption-and-interest-pages-to-ts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-1079