Skip to content

geocode SLC integration test #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Mar 6, 2023
+303 −31
Merged

geocode SLC integration test #46

Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
6b02edd
initial commit for geocode SLC unit test
LiangJYu Aug 8, 2022
fd880ed
download test data from zenodo
LiangJYu Aug 15, 2022
9f0b607
added docstrings, more descriptive variable names, internet check
LiangJYu Sep 12, 2022
97c4461
Merge branch 'main' into geocode_slc_unit_test
LiangJYu Oct 20, 2022
2984d49
run integration test in circleci
LiangJYu Oct 20, 2022
1abbfe4
adding pytest as requirement
LiangJYu Oct 24, 2022
92daa0f
adding pytest to docker specfile
LiangJYu Oct 28, 2022
0164652
another attempt to run pytest in ci
LiangJYu Oct 28, 2022
ebfea34
yet another attempt to run pytest in ci
LiangJYu Oct 28, 2022
13cb5b2
applying suggestion from rtburns
LiangJYu Nov 2, 2022
7a5655c
docker command tweak
LiangJYu Nov 2, 2022
6442402
fix entry point
LiangJYu Nov 3, 2022
cd70f7c
remove entry point
LiangJYu Nov 4, 2022
6e3069c
fix path
LiangJYu Nov 8, 2022
8eff671
activate environment
LiangJYu Nov 8, 2022
175ab31
init bash
LiangJYu Nov 8, 2022
c65ace4
bash path not needed
LiangJYu Nov 9, 2022
17a70ff
docker command fix
LiangJYu Nov 9, 2022
dbf457b
adding attr to specifile
LiangJYu Nov 16, 2022
7e34b3f
fix typo in url
LiangJYu Nov 16, 2022
35cb9e8
Merge remote-tracking branch 'upstream/main' into geocode_slc_unit_test
LiangJYu Dec 3, 2022
5b4dc91
updated specfile
LiangJYu Dec 5, 2022
07c83e4
account for multiburst, new burst ID, geocode entire burst
LiangJYu Dec 5, 2022
b30f823
use main instead of tag because of missing features
LiangJYu Dec 6, 2022
18c9cb4
clone hhtps not ssh
LiangJYu Dec 6, 2022
4ddf5f8
template yaml
LiangJYu Dec 6, 2022
aa1540c
Merge branch 'main' into geocode_slc_unit_test
LiangJYu Feb 17, 2023
8e10100
update unit tests for smaller dataset
LiangJYu Feb 21, 2023
88f0487
parallel test data download
LiangJYu Feb 23, 2023
d438b58
update specifile
LiangJYu Feb 23, 2023
dd2e841
remove unused imports
LiangJYu Feb 23, 2023
e693f51
more comments/docstrings
LiangJYu Feb 23, 2023
aeb64ac
cleaner mp pool
LiangJYu Feb 25, 2023
3f72ad3
fix docstring
LiangJYu Feb 25, 2023
b95f45c
load just the slice not EVERYTHING
LiangJYu Feb 25, 2023
8953342
Merge branch 'geocode_slc_unit_test' of github.com:LiangJYu/COMPASS i…
LiangJYu Feb 25, 2023
dd7b5e1
clarity in file related variable
LiangJYu Mar 2, 2023
fa33f64
fix typo in path
LiangJYu Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
load just the slice not EVERYTHING
  • Loading branch information
@LiangJYu
LiangJYu committed Feb 25, 2023
commit b95f45cf125d7e3a9a0755930ca92fcba48a337b
2 changes: 1 addition & 1 deletion tests/test_s1_geocode_slc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def test_geocode_slc_validate(geocode_slc_params):

# slice raster array
with h5py.File(geocode_slc_params.output_hdf5, 'r') as h5_obj:
arr = h5_obj[geocode_slc_params.raster_path][()][s_]
arr = h5_obj[geocode_slc_params.raster_path][s_]

# check for bright spots in sliced array
corner_reflector_threshold = 3e3
Copy link

@vbrancat vbrancat Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How have you determined this threshold? Also, I do not fully understand the test. We are just testing for the presence of bright spots inside the processed CSLC?

Copy link
Contributor Author

@LiangJYu LiangJYu Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct - this test only check for presence of bright spots in the processed CSLC within the area of the CRs. I was thinking to improve this to checking for individual CRs when we get all our corrections implemented.

I determined the threshold by plotting where the CRs are and picked a seemingly appropriate value based on the colorbar.

Expand Down