geocode SLC integration test #46
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,15 @@ | ||
| python>=3.9 # sentinel1-reader requirement | ||
| numpy # sentinel1-reader requirement | ||
| lxml # sentinel1-reader requirement | ||
| gdal>=3 | ||
| #isce3 # since the conda-installed isce3 is not the most updated version, installing isce3 from stratch is recommended, to stay in sync with isce3 development. | ||
| #journal # as of Mar 2022, journal from conda does not support python3.9; since it is included during isce3 installation above, comment this out temporarily. | ||
|
There was a problem hiding this comment. It's still here - 3 lines above |
||
| pandas | ||
| pyproj | ||
| pytest | ||
| ruamel.yaml | ||
| scipy | ||
| yamale | ||
| h5py | ||
| shapely | ||
|
There was a problem hiding this comment. I though this dependency comes from There was a problem hiding this comment. When trying to build an environment from scratch, I recall needing to add these. I will try again and see if we can do without. There was a problem hiding this comment. If There was a problem hiding this comment. For h5py and shapely- aren't those things that we use specifically in here? It seems like we wouldn't want to rely on a chain of dependencies. e.g. if isce3 got rid of There was a problem hiding this comment. Good point ☝️ Regardless it's innocuous to have these items in requirements.txt right? |
||
| requests | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| runconfig: | ||
| groups: | ||
| dynamic_ancillary_file_group: | ||
| dem_file: @DATA_PATH@/test_dem.tiff | ||
| static_ancillary_file_group: | ||
| burst_database_file: @DATA_PATH@/test_burst_map.sqlite3 | ||
| input_file_group: | ||
| burst_id: | ||
| - @BURST_ID@ | ||
| orbit_file_path: | ||
| - @DATA_PATH@/orbits/S1A_OPER_AUX_POEORB_OPOD_20221105T083813_V20221015T225942_20221017T005942.EOF | ||
| safe_file_path: | ||
| - @DATA_PATH@/S1A_IW_SLC__1SDV_20221016T015043_20221016T015111_045461_056FC0_6681.zip | ||
| pge_name_group: | ||
| pge_name: CSLC_S1_PGE | ||
| primary_executable: | ||
| product_type: CSLC_S1 | ||
| processing: | ||
| rdr2geo: | ||
| enabled: false | ||
| geo2rdr: | ||
| lines_per_block: 1000 | ||
| numiter: 25 | ||
| threshold: 1.0e-08 | ||
| geocoding: | ||
| flatten: true | ||
| lines_per_block: 1000 | ||
| x_posting: 5 | ||
| x_snap: null | ||
| y_posting: 10 | ||
| y_snap: null | ||
| polarization: co-pol | ||
| range_split_spectrum: | ||
| enabled: False | ||
| product_path_group: | ||
| product_path: @TEST_PATH@/product | ||
| sas_output_file: @TEST_PATH@/product | ||
| scratch_path: @TEST_PATH@/scratch | ||
| worker: | ||
| gpu_enabled: false | ||
| gpu_id: 0 | ||
| internet_access: false | ||
| name: cslc_s1_workflow_default |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are getting created in the test directory and we want to ignore them, what if we use a temporary pytest directory that'll get removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E.g. in conftest.py, using https://docs.pytest.org/en/7.1.x/how-to/tmp_path.html#the-tmp-path-factory-fixture
But now that i've written this out, I'm thinking you may have stored it in the
tests/directory so that you could inspect the output, so feel free to ignore this suggestion if that's the caseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your reasoning for the scratch directory is spot on.
tempfile.TemporaryDirectorycould be used just for unit tests but would disable ability to check intermediate results.