When grouping shares, sort by stime then id

[PVince81]

Description

If share times are equal, the first share should still win instead of
having the shares swapped.

Related Issue

Fixes #25830

Motivation and Context

Because it makes tests randomly fail.

How Has This Been Tested?

Not possible to humanly manual test this.
You can hower swap -1 and 1 before this fix and see how it makes the test from #25830 fail. This clearly shows the when running the tests, sometimes the shares a swapped, likely when their share time is equal.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

@SergioBertolinSG @jvillafanez @DeepDiver1975 @PhilippSchaffrath

[mention-bot]

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 to be a potential reviewer.

[DeepDiver1975]

👍

[DeepDiver1975]

• stable9.1: [stable9.1] When grouping shares, sort by stime then id #26784

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.