[stable9.1] When grouping shares, sort by stime then id #26784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If share times are equal, the first share should still win instead of having the shares swapped.
|
@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81 to be a potential reviewer. |
9 tasks
Contributor
|
Not critical, would rather merge for 9.1.4. It only made the tests fail because the test expected a specific behavior. |
PVince81
deleted the
stable9.1-1d973b2a51eb5f850616d741d61612705463d92c
branch
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #26777