Skip to content

Selenium test for PR 26979 #27057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
individual-it wants to merge 18 commits into from
Closed

Selenium test for PR 26979 #27057

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4655413
added facebook selenium webdriver
individual-it Jan 27, 2017
014465a
setup selenium tests env.
individual-it Jan 27, 2017
f1b4fa4
make travis run the selenium tests
individual-it Jan 27, 2017
8d45e08
set propper test name
individual-it Jan 27, 2017
28e52d9
user global namespace for WebDriverBy
individual-it Jan 27, 2017
a26ac55
run selenium tests ony when sauce connector is configured
individual-it Jan 30, 2017
ed4dc56
Whitespace
Jan 30, 2017
4cba2a9
restore admin file and folder to default
individual-it Jan 30, 2017
6dcd270
Merge branch 'selenium-implementation' of https://github.com/individu…
individual-it Jan 30, 2017
71936fd
adminLogin() for selenium tests
individual-it Jan 30, 2017
2661d96
selenium test for PR #26979
individual-it Jan 30, 2017
151375c
adminLogin description
Jan 31, 2017
8612a48
make the selenium test a travis testcase
individual-it Jan 31, 2017
4399bab
add webdriver bindings as composer dependency
individual-it Jan 31, 2017
fbd00f0
update composer.lock for facebook webdriver
individual-it Jan 31, 2017
3e3302d
better way of waiting
individual-it Feb 1, 2017
13fbc37
fix code style & indent
individual-it Feb 1, 2017
0387df5
Merge pull request #8 from individual-it/selenium-better-waiting
individual-it Feb 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
run selenium tests ony when sauce connector is configured 
only run the selenium tests whe SAUCE_USERNAME & SAUCE_ACCESS_KEY are
configured. That way a PR from an external, that does not have access to
the sauce env., will not trigger the selenium tests
  • Loading branch information
@individual-it
individual-it committed Jan 30, 2017
commit a26ac5501ecfa3ad55fe43624eb75de2143e3624
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ env:
global:
- TEST_DAV=$(tests/travis/changed_app.sh dav)
- TC=litmus-v2
- TEST_SELENIUM=1
- SRV_HOST_NAME=owncloud
- SRV_HOST_PORT=8888
matrix:
Expand All @@ -39,6 +38,7 @@ addons:

before_install:
- make
- if [ ! -z "$SAUCE_USERNAME" ] && [ ! -z "$SAUCE_ACCESS_KEY" ]; then export TEST_SELENIUM=1 ; else export TEST_SELENIUM=0 ; fi
Copy link
Member

@DeepDiver1975 DeepDiver1975 Jan 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add this as a test case just like we do with caldav, carddav.

Copy link
Member Author

@individual-it individual-it Jan 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to prevent the tests to run if a PR comes from a remote fork.
So if we make it a test-case by setting TEST_SELENIUM=1 and the sauce_connector is setup in owncloud/core and I make a fork to individual-it/core commit something and make a PR. Travis would try to build that PR but the selenium tests would fail because $SAUCE_USERNAME & $SAUCE_ACCESS_KEY are not set

Copy link
Member

@DeepDiver1975 DeepDiver1975 Jan 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that part - we can still make this work (somehow ;-) )

But on travis I'd like to see an explicit job with TC=selenium listed

- sh -c "if [ '$TEST_DAV' = '1' ] || [ '$TEST_SELENIUM' = '1' ]; then bash tests/travis/before_install.sh $DB; fi"

install:
Expand Down