Selenium test for PR 26979 #27057

individual-it · 2017-01-31T05:57:32Z

Description

This is a slenium test for the PR #26979 that fixes the issue #26975
It depends on PR #27056 (Selenium implementation)

Related Issue

PR #26979
issue #26975

Motivation and Context

See issue #27055 & PR #27056

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

the tests are run on http://saucelabs.com/

only run the selenium tests whe SAUCE_USERNAME & SAUCE_ACCESS_KEY are configured. That way a PR from an external, that does not have access to the sauce env., will not trigger the selenium tests

…al-it/owncloud-core into selenium-implementation

login into oC with admin credentials

This is a test for the PR #26979 that was done to fix the issue #26975

Everything in this branch looks good.

mention-bot · 2017-01-31T05:57:33Z

@individual-it, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 and @PVince81 to be potential reviewers.

DeepDiver1975 · 2017-01-31T07:57:06Z

tests/vendor/facebook/webdriver/example.php

@@ -0,0 +1,49 @@
+<?php


please do not add the vendor directory

so do you want the webdriver be in tests/facebook/webdriver ?

I'd add this as dev dependency into /composer.json

DeepDiver1975 · 2017-01-31T07:58:32Z

.travis.yml

 before_install:
  - make
-  - sh -c "if [ '$TEST_DAV' = '1' ]; then bash tests/travis/before_install.sh $DB; fi"
+  - if [ ! -z "$SAUCE_USERNAME" ] && [ ! -z "$SAUCE_ACCESS_KEY" ]; then export TEST_SELENIUM=1 ; else export TEST_SELENIUM=0 ; fi


let's add this as a test case just like we do with caldav, carddav.

this is to prevent the tests to run if a PR comes from a remote fork.
So if we make it a test-case by setting TEST_SELENIUM=1 and the sauce_connector is setup in owncloud/core and I make a fork to individual-it/core commit something and make a PR. Travis would try to build that PR but the selenium tests would fail because $SAUCE_USERNAME & $SAUCE_ACCESS_KEY are not set

I understand that part - we can still make this work (somehow ;-) )

But on travis I'd like to see an explicit job with TC=selenium listed

individual-it · 2017-01-31T11:17:55Z

I've made the requested changes. Tests are passing on my travis instance: https://travis-ci.org/individual-it/owncloud-core/builds/196904627
Somehow composer decided to change the time format in composer.lock

DeepDiver1975 · 2017-01-31T13:16:12Z

Somehow composer decided to change the time format in composer.lock

this is okay - nothing to worry from my pov

DeepDiver1975 · 2017-01-31T13:18:51Z

We need to fix the regular phpunit execution as done on jenkins.
The selenium tests are executed as well.
Maybe we move the selenium tests into a different folder.

@PVince81 @SergioBertolinSG integration tests will stay in build/integration? What is the current play?

Otherwise I suggest to restructure the tests folder:

tests
- unit (move all unit tests in here)
- integration tests (move build/integration in here)
- ui (move all selenium tests are of this pr)

objections?

individual-it · 2017-01-31T13:27:27Z

The even more basic question is were do you like to have the selenium tests run? I've set it up on Travis cause it's all public, free of costs and easy to set up, but you also could run it on/through your Jenkins architecture

…

On January 31, 2017 7:03:59 PM GMT+05:45, "Thomas Müller" ***@***.***> wrote: We need to fix the regular phpunit execution as done on jenkins. The selenium tests are executed as well. Maybe we move the selenium tests into a different folder. @PVince81 @SergioBertolinSG integration tests will stay in build/integration? What is the current play? Otherwise I suggest to restructure the tests folder: - tests - unit (move all unit tests in here) - integration tests (move build/integration in here) - ui (move all selenium tests are of this pr) objections? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #27057 (comment)

DeepDiver1975 · 2017-01-31T13:30:01Z

The even more basic question is were do you like to have the selenium tests run?

As far as I can tell: travis is fine for me - let's see how this evolves. We can always move these tests to jenkins.

DeepDiver1975 · 2017-01-31T13:30:29Z

In any case: @individual-it thanks a lot for the effort you put into this! Much appreciated!

SergioBertolinSG · 2017-01-31T13:38:55Z

I think we should use behat mink for this http://mink.behat.org/en/latest/
and make use of the page object pattern.

The tests which find the elements using xpath can break easily, that requires an improvement of the frontend to include proper ids to every element.

individual-it · 2017-02-01T10:37:54Z

I totally agree that relying on xpath might be problematic, depending on how you use it.
is good: WebDriverBy::xpath(".//table[@id='userlist']")
is fine: WebDriverBy::xpath(".//*[@id='app-content']/div[@class='loading']")
problematic: WebDriverBy::xpath(".//*table[@class='hascontrols']/tbody/tr[2]/th

use of page object pattern sounds very good to me. Selenium-documentation on Page Objects Its basically the question about how much to generalize and reuse the code. And more reuse of code if of course better.
Within your web app's UI there are areas that your tests interact with. A Page Object simply models these as objects within the test code. This reduces the amount of duplicated code and means that if the UI changes, the fix need only be applied in one place.
If the concept of UI testing with selenium is taken onboard for oC I'm happy to write a couple PageObjects for general use

You can make mink drive selenium on sauce-labs.
How do you think it would benefit oC to use behat & mink? Do you think of changing from PHPUnit to Behat? Or is it about using Gherkin as language?
How much chance/need is to go on behavior-driven development (BDD) for oC?

individual-it · 2017-02-01T11:46:20Z

I've converted my Sauce Labs account into a OSS account and that makes the tests public. If someone is interested in seeing this test+result on sauce labs site here it is: https://saucelabs.com/beta/tests/53361d4a9812466a87027fdb5a4b0109/commands#0

Selenium better waiting & nicer code formatting

PVince81 · 2017-02-06T14:40:06Z

restructure the tests folder

@DeepDiver1975 sounds good

SergioBertolinSG · 2017-02-07T07:57:28Z

You can make mink drive selenium on sauce-labs.
How do you think it would benefit oC to use behat & mink? Do you think of changing from PHPUnit to Behat? Or is it about using Gherkin as language?
How much chance/need is to go on behavior-driven development (BDD) for oC?

To be consistent with the current integration tests suite which are already using behat. Also easier to create new tests and understand them.

michaelstingl · 2017-02-07T08:11:29Z

+1 for behat

individual-it · 2017-02-09T02:48:43Z

@SergioBertolinSG I just watched your behat presentation on owncloud https://www.youtube.com/watch?v=_Sbgctq1P1U
As far as I understood you are running the behat tests on Jenkins. So if the UI tests were done in behat would you run them also on Jenkins or try to run the UI behat still on travis as @DeepDiver1975 proposed?

individual-it · 2017-02-15T02:37:15Z

Closing this and will make a new PR with a behat / mink solution

lock · 2019-08-03T22:02:48Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

individual-it and others added 12 commits January 27, 2017 14:07

added facebook selenium webdriver

4655413

setup selenium tests env.

014465a

make travis run the selenium tests

f1b4fa4

the tests are run on http://saucelabs.com/

set propper test name

8d45e08

user global namespace for WebDriverBy

28e52d9

run selenium tests ony when sauce connector is configured

a26ac55

only run the selenium tests whe SAUCE_USERNAME & SAUCE_ACCESS_KEY are configured. That way a PR from an external, that does not have access to the sauce env., will not trigger the selenium tests

Whitespace

ed4dc56

restore admin file and folder to default

4cba2a9

Merge branch 'selenium-implementation' of https://github.com/individu…

6dcd270

…al-it/owncloud-core into selenium-implementation

adminLogin() for selenium tests

71936fd

login into oC with admin credentials

selenium test for PR #26979

2661d96

This is a test for the PR #26979 that was done to fix the issue #26975

adminLogin description

151375c

Everything in this branch looks good.

individual-it added the 3 - To Review label Jan 31, 2017

DeepDiver1975 added this to the 10.0 milestone Jan 31, 2017

DeepDiver1975 requested changes Jan 31, 2017

View reviewed changes

individual-it added 3 commits January 31, 2017 16:47

make the selenium test a travis testcase

8612a48

add webdriver bindings as composer dependency

4399bab

update composer.lock for facebook webdriver

fbd00f0

individual-it added 2 commits February 1, 2017 18:34

better way of waiting

3e3302d

fix code style & indent

13fbc37

Merge pull request #8 from individual-it/selenium-better-waiting

0387df5

Selenium better waiting & nicer code formatting

PVince81 mentioned this pull request Feb 7, 2017

Restructure tests for avoiding duplicated code. owncloud/QA#376

Closed

individual-it closed this Feb 15, 2017

This was referenced Feb 15, 2017

Selenium implementation #27056

Closed

UI test for PR #26979 #27191

Closed

individual-it mentioned this pull request Mar 6, 2017

UI test for PR #26979 #27316

Merged

9 tasks

lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019

Selenium test for PR 26979 #27057

Selenium test for PR 26979 #27057

Uh oh!

Conversation

individual-it commented Jan 31, 2017

Description

Related Issue

Motivation and Context

Types of changes

Checklist:

Uh oh!

mention-bot commented Jan 31, 2017

Uh oh!

DeepDiver1975 Jan 31, 2017

Choose a reason for hiding this comment

Uh oh!

individual-it Jan 31, 2017

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 Jan 31, 2017

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 Jan 31, 2017

Choose a reason for hiding this comment

Uh oh!

individual-it Jan 31, 2017

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 Jan 31, 2017

Choose a reason for hiding this comment

Uh oh!

individual-it commented Jan 31, 2017

Uh oh!

DeepDiver1975 commented Jan 31, 2017

Uh oh!

DeepDiver1975 commented Jan 31, 2017

Uh oh!

individual-it commented Jan 31, 2017 via email

Uh oh!

DeepDiver1975 commented Jan 31, 2017

Uh oh!

DeepDiver1975 commented Jan 31, 2017

Uh oh!

SergioBertolinSG commented Jan 31, 2017

Uh oh!

individual-it commented Feb 1, 2017

Uh oh!

individual-it commented Feb 1, 2017

Uh oh!

PVince81 commented Feb 6, 2017

Uh oh!

SergioBertolinSG commented Feb 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michaelstingl commented Feb 7, 2017

Uh oh!

individual-it commented Feb 9, 2017

Uh oh!

individual-it commented Feb 15, 2017

Uh oh!

lock bot commented Aug 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SergioBertolinSG commented Feb 7, 2017 •

edited

Loading