UI tests for renaming feature #27872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
individual-it
force-pushed
the
ui-tests-rename-feature
branch
from
0a2aa0b to
e8e6456
Compare
individual-it
changed the title
need to get this PR 244 MinkSelenium2Driver It fixes an issue with typing into autocomplete boxes
This was never needed, only after updating mink-selenium2-driver And then it would not give any usefull output why it failed only Expected to be on "http://localhost/owncloud-core/index.php/login" but found "" instead (SensioLabs\Behat\PageObjectExtension\PageObject\Exception\UnexpectedPageException) Had to do network sniffing beween mink and saucelabs proxy to find out that it reported: The requested combination of browser, version and OS is unsupported by the requested Selenium version and would lead to a test failure. Please set a different Selenium version, or set none to get the default, working Selenium version for this platform: firefox 47.0. on Windows 2008 with Selenium 2.31.0 What is also not true, because the correct version of selenium has to be 2.53.1 as per documentation: https://wiki.saucelabs.com/display/DOCS/Test+Configuration+Options#TestConfigurationOptions-SeleniumVersion
individual-it
force-pushed
the
ui-tests-rename-feature
branch
from
21cc1c9 to
93198f1
Compare
9 tasks
9 tasks
this was needed after updating mink-selenium2-driver before update FF returned: <option value="default" selected="selected">Default</option> after update: <option value="default">Default</option> if no option is selected the first one is selected, so getQuotaOfUser now finds the value of the select field and then returns the text that is associated with that value
double quotes are not valid characters in filenames in Windows, having them in the repro would result Windows user not beeing able to clone
phil-davis
approved these changes
May 22, 2017
Contributor
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
Looks good now. The little bug that was found has been fixed in master - so testing attempts to rename to an existing file name now pass. Other hassles with Firefox versions and the latest Mink/Selenium versions are sorted. These tests should run reliably.
individual-it
changed the title
Member
|
@individual-it @phil-davis please hold your horses for now in merging further PRs - we are right in the middle of finishing the PR - we needs as little interruptions as possible - THX |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UI tests for renaming files
and a lot of underlying page Object stuff
Related Issue
https://github.com/owncloud/QA/blob/master/Server/Test_Plan_WebDav_Interface_WebUI.md
This tests should cover:
3. Rename a file using special characters
5. Rename a file putting a name of a file which already exists
6. Try to rename a file using forbidden characters
Motivation and Context
make Test plan run automatically
https://github.com/owncloud/QA/blob/master/Server/Test_Plan_WebDav_Interface_WebUI.md
How Has This Been Tested?
run the tests in Chrome on local machine
Types of changes
Checklist: