Fix check behat exit

[individual-it]

Description

the exit code of behat running selenium tests was not checked correctly
this resulted in showing failed test as passed in travis & saucelabs

Related Issue

#27879

How Has This Been Tested?

locally & by cherry picking the commits to #27872

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[phil-davis]

Here is a test build without this change: https://travis-ci.org/individual-it/owncloud-core/builds/232406044?utm_source=github_status&utm_medium=notification
I purposely made a test that would fail, and this Job shows the scenario failure in it: https://travis-ci.org/individual-it/owncloud-core/jobs/232406052
but the status is not passed back, and Travis thinks that the Job and thus the whole Build passed, when actually it failed.

Here is a test build with the same bad test, and this change to pass back the status properly: https://travis-ci.org/individual-it/owncloud-core/jobs/232406052
Each of the 4 selenium jobs show as failed (as they should), e.g.: https://travis-ci.org/individual-it/owncloud-core/jobs/232408321

So this is "a good thing".

[phil-davis]

Hmm @individual-it why did Job https://travis-ci.org/owncloud/core/jobs/232354259 fail with messages about scenarios "Failed asserting that two strings are equal."?

[individual-it]

restarting the job did fix it

[phil-davis]

Always good to know that the traditional support "fix" even works here - restart or reboot ;)

[PVince81]

👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.