Add extra check in case of missing home storage #28432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomneedham
approved these changes
Jul 19, 2017
Contributor
tomneedham
left a comment
tomneedham
left a comment
There was a problem hiding this comment.
Code looks good + tested scan command locally.
This was referenced Jul 27, 2017
Contributor
Author
Contributor
Author
|
stable9: #29046 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case the scanner finds out that either the root or "files" folder is missing on a home storage, throw a
StorageNotAvailableExceptionto prevent potential side effects. This situation can happen in some FS mount scenarios where the mount is missing.Related Issue
https://github.com/owncloud/enterprise/issues/2050
https://github.com/owncloud/enterprise/issues/2080
Motivation and Context
Because we don't like it when sometimes clients might think that the home is empty or when ownCloud decides to recreate the home folder because it's missing.
How Has This Been Tested?
Unit test
Screenshots (if appropriate):
Types of changes
Checklist: