Skip to content

[stable9.1] Add extra check in case of missing home storage #28505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DeepDiver1975 merged 2 commits into from
Oct 30, 2017
Merged

[stable9.1] Add extra check in case of missing home storage #28505

DeepDiver1975 merged 2 commits into from
Oct 30, 2017

Conversation

@PVince81
Copy link
Contributor

@PVince81 PVince81 commented Jul 27, 2017

Backport of #28432 to stable9.1.

Need retesting.

@PVince81 PVince81 added this to the development milestone Jul 27, 2017
@PVince81 PVince81 requested a review from tomneedham July 27, 2017 08:46
@PVince81 PVince81 mentioned this pull request Jul 27, 2017
Merged
9 tasks
@PVince81 PVince81 force-pushed the stable9.1-scanner-detectmissinghome branch from ed8e9ad to b4ad753 Compare August 1, 2017 08:21
@PVince81
Copy link
Contributor Author

PVince81 commented Aug 1, 2017

fixed createMock for old phpunit

@PVince81
Copy link
Contributor Author

PVince81 commented Aug 1, 2017 

10:31:24 1) TrashbinTest::testExpireOldFilesShared
10:31:24 OCP\Files\StorageNotAvailableException: Missing important folder "files" in home storage - home::test-trashbin-user2
10:31:24 
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Cache/Scanner.php:119
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Cache/Scanner.php:150
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Cache/Watcher.php:105
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/View.php:1307
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/View.php:1343
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Node/Root.php:180
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Node/Folder.php:117
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Node/Root.php:358
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Server.php:813
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/apps/files_trashbin/tests/TrashbinTest.php:672
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/apps/files_trashbin/tests/TrashbinTest.php:235
10:31:24 
10:31:24 2) OCA\Files_Versions\Tests\VersioningTest::testRenameInSharedFolder
10:31:24 OCP\Files\StorageNotAvailableException: Missing important folder "files" in home storage - home::test-versions-user2
10:31:24 
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Cache/Scanner.php:119
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Cache/Scanner.php:150
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Cache/Watcher.php:105
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/View.php:1307
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/View.php:1343
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Node/Root.php:180
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Node/Folder.php:117
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Node/Root.php:358
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Server.php:813
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/apps/files_versions/tests/VersioningTest.php:905
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/apps/files_versions/tests/VersioningTest.php:327
10:31:24 
10:31:24 3) OCA\Files_Versions\Tests\VersioningTest::testMoveFolderIntoSharedFolderAsRecipient
10:31:24 OCP\Files\StorageNotAvailableException: Missing important folder "files" in home storage - home::test-versions-user2
10:31:24 
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Cache/Scanner.php:119
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Cache/Scanner.php:150
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Cache/Watcher.php:105
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/View.php:1307
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/View.php:1343
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Node/Root.php:180
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Node/Folder.php:117
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Node/Root.php:358
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Server.php:813
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/apps/files_versions/tests/VersioningTest.php:905
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/apps/files_versions/tests/VersioningTest.php:444
10:31:24 
10:31:24 4) OCA\Files_Versions\Tests\VersioningTest::testRestoreNoPermission
10:31:24 OCP\Files\StorageNotAvailableException: Missing important folder "files" in home storage - home::test-versions-user2
10:31:24 
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Cache/Scanner.php:119
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Cache/Scanner.php:150
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Cache/Watcher.php:105
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/View.php:1307
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/View.php:1343
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Node/Root.php:180
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Node/Folder.php:117
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Files/Node/Root.php:358
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/lib/private/Server.php:813
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/tests/lib/TestCase.php:341
10:31:24 /var/lib/jenkins/workspace/owncloud-core_core_PR-28505-3TRPAGZJ43NCVPOHX36J7XNDOI3MEHO2TPRR6ELOECZ3EZB7BDXA/apps/files_versions/tests/VersioningTest.php:662
10:31:24

Seems we'll need to adjust these tests to properly initialize the storages

@PVince81 PVince81 self-assigned this Aug 3, 2017
@PVince81
Copy link
Contributor Author

PVince81 commented Sep 18, 2017

Argh... running these test suites individually works fine. It's likely that when running the full suite, something is destroying the test storages or preventing them to come back up again.

Recreate "files" folder in trashbin and versioning tests
846f8d7 
This is to prevent the safety check to kick in because the "files"
folder is missing.
@PVince81
Copy link
Contributor Author

PVince81 commented Sep 18, 2017

Ok, so on stable10 it works fine because the skeleton copy is happening much earlier now.

Here on stable9.1 the versioning and trashbin tests are deleting the "files" folder at the end of tests, so trying to $node->get() these folders fail due to the safety check, since in stable9.1 the skeleton copy happens later. The fix for the tests is to simply recreate the "files" folders after removing their contents in tearDown.

@PVince81 PVince81 requested a review from butonic September 18, 2017 12:58
@PVince81 PVince81 modified the milestones: 10.0.3, development Sep 18, 2017
@DeepDiver1975 DeepDiver1975 merged commit 5334874 into stable9.1 Oct 30, 2017
@DeepDiver1975 DeepDiver1975 deleted the stable9.1-scanner-detectmissinghome branch October 30, 2017 15:03
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@tomneedham tomneedham Awaiting requested review from tomneedham

@butonic butonic Awaiting requested review from butonic

Assignees

@PVince81 PVince81

Labels

3 - To Review status/STALE

Projects

None yet

Milestone

10.0.5

Development

Successfully merging this pull request may close these issues.

4 participants

@PVince81 @DeepDiver1975 @ownclouders