Ocm to groups 20230717

[phil-davis]

Description

I have cherry-picked the real commits from the 221 commits currently in PR #40589

I think that this PR has the real code changes, with all the "merge to/from master" stuff that has got in there somehow.

Maybe this PR will be easier to review.

Related Issue

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[jvillafanez]

I think we should change this variable name, and other related ones.
I thought this was referring to the share constants (from the "lib/private/Share/Constants.php" file) but it doesn't seem to be the case. That's why I suggested to use a constant for the comparison below.

[phil-davis]

https://drone.owncloud.com/owncloud/core/38747/58/14

        Failed step: When user "Alice" gets the following properties of file "/tmp.txt" using the WebDAV API
        WebDav::listFolderAndReturnResponseXml Exception parsing response body: "<?xml version="1.0"?>
        <d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:oc="http://owncloud.org/ns"<?xml version="1.0" encoding="utf-8"?>
        <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
          <s:exception>Error</s:exception>
          <s:message>Call to a member function getExpirationDate() on null</s:message>
        </d:error>
        " (Exception)

Quite a lot of test scenarios are failing. I was hoping that I could just cherry-pick the relevant code from #40589 and have a "clean" PR with green CI. But it seems not to be.

@michielbdejong @navid-shokri @soltanireza65 and/or whoever is getting this code going - maybe you can clean up your original PR and get it passing again?

[pako81]

@phil-davis close in favour of #40886 (which is getting green CI) ?

[phil-davis]

Yes, that has cleaned-up code with green CI.