Accept OCM to groups

Signed-off-by: Michiel de Jong <[email protected]>

apps/dav/lib/Connector/Sabre/SharesPlugin.php

@@ -133,7 +133,9 @@ private function getSharesForNodeIds($nodeIDs) {
 			\OCP\Share::SHARE_TYPE_USER,
 			\OCP\Share::SHARE_TYPE_GROUP,
 			\OCP\Share::SHARE_TYPE_LINK,
-			\OCP\Share::SHARE_TYPE_REMOTE
+			\OCP\Share::SHARE_TYPE_REMOTE,
+			\OCP\Share::SHARE_TYPE_REMOTE_GROUP
+
 		];
 
 		// Query DB for share types for specified node IDs

apps/federatedfilesharing/lib/AppInfo/Application.php

@@ -140,7 +140,8 @@ function ($c) use ($server) {
 					$server->getUserManager(),
 					$c->query('AddressHandler'),
 					$c->query('FederatedShareManager'),
-					$server->getLogger()
+					$server->getLogger(),
+					$server->getConfig()
 				);
 			}
 		);

apps/federatedfilesharing/lib/Controller/OcmController.php

@@ -36,6 +36,8 @@
 use OCP\IRequest;
 use OCP\IURLGenerator;
 use OCP\IUserManager;
+use OCP\IConfig;
+use OCP\Share\Exceptions\ShareNotFound;
 
 /**
  * Class OcmController
@@ -75,6 +77,11 @@ class OcmController extends Controller {
 	 */
 	protected $logger;
 
+	/**
+	 * @var IConfig
+	 */
+	protected $config;
+
 	/**
 	 * OcmController constructor.
 	 *
@@ -86,6 +93,7 @@ class OcmController extends Controller {
 	 * @param AddressHandler $addressHandler
 	 * @param FedShareManager $fedShareManager
 	 * @param ILogger $logger
+	 * @param IConfig $config
 	 */
 	public function __construct(
 		$appName,
@@ -95,7 +103,8 @@ public function __construct(
 		IUserManager $userManager,
 		AddressHandler $addressHandler,
 		FedShareManager $fedShareManager,
-		ILogger $logger
+		ILogger $logger,
+		IConfig $config
 	) {
 		parent::__construct($appName, $request);
 
@@ -105,6 +114,7 @@ public function __construct(
 		$this->addressHandler = $addressHandler;
 		$this->fedShareManager = $fedShareManager;
 		$this->logger = $logger;
+		$this->config = $config;
 	}
 
 	/**
@@ -177,6 +187,14 @@ public function createShare(
 		$resourceType,
 		$protocol
 	) {
+		// Allow other apps to overwrite the behaviour of this endpoint
+		if ($shareType === 'group') {
+			$controllerClass = $this->config->getSystemValue('sharing.ocmController');
+			if ($controllerClass !== '') {
+				$controller = \OC::$server->query($controllerClass);
+				return $controller->createShare(...\func_get_args());
+			}
+		}
 		try {
 			$this->ocmMiddleware->assertIncomingSharingEnabled();
 			$this->ocmMiddleware->assertNotNull(
@@ -284,6 +302,12 @@ public function processNotification(
 		$providerId,
 		$notification
 	) {
+		// Allow other apps to overwrite the behaviour of this endpoint
+		$controllerClass = $this->config->getSystemValue('sharing.ocmController');
+		if ($controllerClass !== '') {
+			$controller = \OC::$server->query($controllerClass);
+			return $controller->processNotification(...\func_get_args());
+		}
 		try {
 			if (!\is_array($notification)) {
 				throw new BadRequestException(

apps/federatedfilesharing/tests/Controller/OcmControllerTest.php

@@ -33,6 +33,7 @@
 use OCA\FederatedFileSharing\Tests\TestCase;
 use OCP\App\IAppManager;
 use OCP\AppFramework\Http;
+use OCP\IConfig;
 use OCP\ILogger;
 use OCP\IRequest;
 use OCP\IURLGenerator;
@@ -107,6 +108,7 @@ protected function setUp(): void {
 		$this->addressHandler = $this->createMock(AddressHandler::class);
 		$this->fedShareManager = $this->createMock(FedShareManager::class);
 		$this->logger = $this->createMock(ILogger::class);
+		$this->config = $this->createMock(IConfig::class);
 
 		$this->ocmController = new OcmController(
 			'federatedfilesharing',
@@ -116,7 +118,8 @@ protected function setUp(): void {
 			$this->userManager,
 			$this->addressHandler,
 			$this->fedShareManager,
-			$this->logger
+			$this->logger,
+			$this->config
 		);
 	}
 

apps/files_sharing/js/app.js

@@ -209,7 +209,7 @@ OCA.Sharing.App = {
 		fileList.fileSummary.$el.find('.filesize').remove();
 	},
 
-	_setShareState: function(fileId, state, isRemote) {
+	_setShareState: function(fileId, state, isRemote, shareType) {
 		var method = 'POST';
 		if (state === OC.Share.STATE_REJECTED) {
 			method = 'DELETE';
@@ -221,6 +221,9 @@ OCA.Sharing.App = {
 			contentType: 'application/json',
 			dataType: 'json',
 			type: method,
+			data: JSON.stringify({
+				...(!!shareType && { shareType }),
+			}),
 		});
 		xhr.fail(function(response) {
 			var message = '';
@@ -236,6 +239,7 @@ OCA.Sharing.App = {
 	_shareStateActionHandler: function(context, newState) {
 		var targetFileData = context.fileList.elementToFile(context.$file);
 		var isRemote = targetFileData.shareLocationType === 'remote';
+		const { shareType } = targetFileData;
 		function responseCallback(response, status) {
 			if (status === 'success') {
 				var meta = response.ocs.meta;
@@ -252,7 +256,7 @@ OCA.Sharing.App = {
 		}
 
 		context.fileList.showFileBusyState(context.$file, true);
-		this._setShareState(context.fileInfoModel.get('shares')[0].id, newState, isRemote)
+		this._setShareState(context.fileInfoModel.get('shares')[0].id, newState, isRemote, shareType)
 			.then(responseCallback);
 	},
 

apps/files_sharing/js/external.js

@@ -142,16 +142,20 @@
 							shares[index],
 							false,
 							function(result, share) {
+								let shareType = "user";
+								if (share.hasOwnProperty('share_type') ){
+									shareType = share.share_type;
+								}
 								if (result) {
 									// Accept
-									$.post(OC.generateUrl('/apps/files_sharing/api/externalShares'), {id: share.id})
+									$.post(OC.generateUrl('/apps/files_sharing/api/externalShares'), {id: share.id, share_type: shareType })
 										.then(function() {
 											fileList.reload();
 										});
 								} else {
 									// Delete
 									$.ajax({
-										url: OC.generateUrl('/apps/files_sharing/api/externalShares/'+share.id),
+										url: OC.generateUrl('/apps/files_sharing/api/externalShares/'+share.id+"?share_type="+shareType),
 										type: 'DELETE'
 									});
 								}

apps/files_sharing/js/share.js

@@ -151,6 +151,8 @@
 									hasShares = true;
 								} else if (shareType === OC.Share.SHARE_TYPE_REMOTE) {
 									hasShares = true;
+								} else if (shareType === OC.Share.SHARE_TYPE_REMOTE_GROUP) {
+									hasShares = true;
 								}
 							});
 							OCA.Sharing.Util._updateFileActionIcon($tr, hasShares, hasLink);

apps/files_sharing/js/sharedfilelist.js

@@ -88,6 +88,7 @@
 			$dateColumn.before($tr.children('td:first'));
 			$tr.find('td.filename input:checkbox').remove();
 			$tr.attr('data-share-location-type', fileData.shareLocationType);
+			$tr.attr('data-share-type', fileData.shareType);
 			$tr.attr('data-share-id', _.pluck(fileData.shares, 'id').join(','));
 			// add row with expiration date for link only shares - influenced by _createRow of filelist
 			if (this._linksOnly) {
@@ -309,7 +310,8 @@
 			}
 
 			fileInfo.shareState = parseInt($el.attr('data-share-state'), 10);
-			fileInfo.shareLocationType =  $el.attr('data-share-location-type');
+			fileInfo.shareLocationType = $el.attr('data-share-location-type');
+			fileInfo.shareType = $el.attr('data-share-type') || "";
 			return fileInfo;
 		},
 
@@ -344,6 +346,7 @@
 			files = _.chain(files)
 				// convert share data to file data
 				.map(function(share) {
+					const {} = share
 					var file = {
 						shareOwner: share.owner + '@' + share.remote.replace(/.*?:\/\//g, ""),
 						shareState: !!parseInt(share.accepted, 10) ? OC.Share.STATE_ACCEPTED : OC.Share.STATE_PENDING,
@@ -355,7 +358,8 @@
 						path: OC.dirname(share.mountpoint),
 						permissions: share.permissions,
 						tags: share.tags || [],
-						shareLocationType: 'remote'
+						shareLocationType: 'remote',
+						shareType: share.share_type || ''
 					};
 
 					file.shares = [{

apps/files_sharing/lib/AppInfo/Application.php

@@ -81,7 +81,8 @@ public function __construct(array $urlParams = []) {
 				$c->query('Request'),
 				$c->query('ExternalManager'),
 				$c->query('HttpClientService'),
-				$server->getEventDispatcher()
+				$server->getEventDispatcher(),
+				$server->getConfig()
 			);
 		});
 
@@ -119,6 +120,7 @@ public function __construct(array $urlParams = []) {
 					$server->getEventDispatcher(),
 					$uid
 				),
+				$server->getConfig(),
 				$uid
 			);
 		});

apps/files_sharing/lib/Controller/RemoteOcsController.php

@@ -29,6 +29,7 @@
 use OCP\Share;
 use OCP\Files\StorageNotAvailableException;
 use OCP\Files\StorageInvalidException;
+use OCP\IConfig;
 
 class RemoteOcsController extends OCSController {
 	/** @var IRequest */
@@ -40,23 +41,31 @@ class RemoteOcsController extends OCSController {
 	/** @var string */
 	protected $uid;
 
+	/**
+	 * @var IConfig
+	 */
+	protected $config;
+
 	/**
 	 * RemoteOcsController constructor.
 	 *
 	 * @param string $appName
 	 * @param IRequest $request
 	 * @param Manager $externalManager
+	 * @param IConfig config
 	 * @param string $uid
 	 */
 	public function __construct(
 		$appName,
 		IRequest $request,
 		Manager $externalManager,
+		IConfig $config,
 		$uid
 	) {
 		parent::__construct($appName, $request);
 		$this->request = $request;
 		$this->externalManager = $externalManager;
+		$this->config = $config;
 		$this->uid = $uid;
 	}
 
@@ -126,6 +135,8 @@ public function declineShare($id) {
 	 */
 	public function getShares($includingPending = false) {
 		$shares = [];
+		$groupExternalManager = null;
+
 		foreach ($this->externalManager->getAcceptedShares() as $shareInfo) {
 			try {
 				$shares[] = $this->extendShareInfo($shareInfo);
@@ -136,6 +147,22 @@ public function getShares($includingPending = false) {
 			}
 		}
 
+		// Allow the Federated Groups app to overwrite the behaviour of this endpoint
+		$managerClass = $this->config->getSystemValue('sharing.groupExternalManager');
+		if ($managerClass !== '') {
+			$groupExternalManager = \OC::$server->query($managerClass);
+
+			foreach ($groupExternalManager->getAcceptedShares() as $shareInfo) {
+				try {
+					$shares[] = $this->extendShareInfo($shareInfo);
+				} catch (StorageNotAvailableException $e) {
+					//TODO: Log the exception here? There are several logs already below the stack
+				} catch (StorageInvalidException $e) {
+					//TODO: Log the exception here? There are several logs already below the stack
+				}
+			}
+		}
+
 		if ($includingPending === true) {
 			/**
 			 * pending shares have mountpoint looking like
@@ -152,7 +179,10 @@ function ($share) {
 					$share['mountpoint'] = \rtrim($share['mountpoint'], '}');
 					return $share;
 				},
-				$this->externalManager->getOpenShares()
+				\array_merge(
+					$this->externalManager->getOpenShares(),
+					$groupExternalManager == null ? [] : $groupExternalManager->getOpenShares()
+				)
 			);
 			$shares = \array_merge($shares, $openShares);
 		}