Sync should happen in core

[tomneedham]

No description provided.

[tomneedham]

Core now takes care of this, after check password the accounts is upserted

[tomneedham]

Since we already retrieved the user from LDAP when core does the sync it can use the cached UserEntry

[tomneedham]

Note: this would target >10.0.8

[codecov-io]

Codecov Report

Merging #156 into master will increase coverage by 0.27%.
The diff coverage is 75%.

@@             Coverage Diff              @@
##             master     #156      +/-   ##
============================================
+ Coverage     34.61%   34.88%   +0.27%     
+ Complexity     1375     1358      -17     
============================================
  Files            32       32              
  Lines          3975     3927      -48     
============================================
- Hits           1376     1370       -6     
+ Misses         2599     2557      -42

Impacted Files	Coverage Δ	Complexity Δ
lib/User_LDAP.php	40.42% <ø> (-0.63%)	36 <0> (ø)
lib/User/Manager.php	50.27% <0%> (+9.38%)	63 <0> (-15)	⬇️
lib/User/UserEntry.php	98.41% <100%> (-0.07%)	54 <0> (-2)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b7cb2...c744561. Read the comment docs.

[tomneedham]

Should this kill setupAccount as well?

[butonic]

@tomneedham setupAccount is code in core

[tomneedham]

This needs to target the version that https://github.com/owncloud/core/pull/30638/commits is released in (10.0.8)

[butonic]

faling stable10 tests until owncloud/core#30638 is merged

[tomneedham]

@ownclouders rebase please

[tomneedham]

Well, I rebased it

[tomneedham]

Just testing this with current stable10 HEAD @ d0ee6a6a403e98a106a61b8f7dfcd06313e0b36c

[butonic]

during testing I was worried that we removed the updateGroups call ... turns out the cache for getMemberOf is never read anyway. also, the group backend queries memberof itself and resolves nested groups. Tracking caching of groups and primarygroupid in #226

[butonic]

also found owncloud-archive/user_management#19 during testing group membership stuff