Skip to content

Conversation

@butonic
Copy link
Member

@butonic butonic commented Feb 6, 2018

fixes #177 if core does not do the sync

@SergioBertolinSG
Copy link
Contributor

Trying to apply this after applying #156 fails.

patching file lib/User/Manager.php
Hunk #1 FAILED at 332.
1 out of 1 hunk FAILED -- saving rejects to file lib/User/Manager.php.rej
patching file lib/User_LDAP.php
Hunk #1 FAILED at 149.
1 out of 1 hunk FAILED -- saving rejects to file lib/User_LDAP.php.rej

@codecov-io
Copy link

codecov-io commented Feb 6, 2018

Codecov Report

Merging #178 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #178   +/-   ##
=========================================
  Coverage     26.29%   26.29%           
  Complexity     1318     1318           
=========================================
  Files            47       47           
  Lines          4487     4487           
=========================================
  Hits           1180     1180           
  Misses         3307     3307
Impacted Files Coverage Δ Complexity Δ
lib/User/Manager.php 42.35% <0%> (ø) 78 <4> (ø) ⬇️
lib/User_LDAP.php 44.55% <100%> (ø) 36 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7fc342...ae7686a. Read the comment docs.

@PVince81
Copy link
Contributor

PVince81 commented Feb 6, 2018

@SergioBertolinSG in any case this tells me that we'll need a new release of this app to fix the encryption problem. Not a blocker for 10.0.7 then.

@tomneedham
Copy link
Contributor

@SergioBertolinSG you do not need to apply 156 first. 156 is giving compatibility with the sync refactoring we did for the next core release. This fix is for ldap to fix the problems in a ldap release .

@tomneedham tomneedham added this to the development milestone Feb 7, 2018
Copy link
Contributor

@SergioBertolinSG SergioBertolinSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, fixes #177

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks fine

@PVince81 PVince81 merged commit 713c48e into master Feb 8, 2018
@PVince81 PVince81 deleted the fix-encryption branch February 8, 2018 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When using encryption, ldap users login for the first time have invalid private keys.

6 participants