-
Notifications
You must be signed in to change notification settings - Fork 20
pass password as it is needed by the encryption #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Trying to apply this after applying #156 fails. |
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=========================================
Coverage 26.29% 26.29%
Complexity 1318 1318
=========================================
Files 47 47
Lines 4487 4487
=========================================
Hits 1180 1180
Misses 3307 3307
Continue to review full report at Codecov.
|
|
@SergioBertolinSG in any case this tells me that we'll need a new release of this app to fix the encryption problem. Not a blocker for 10.0.7 then. |
|
@SergioBertolinSG you do not need to apply 156 first. 156 is giving compatibility with the sync refactoring we did for the next core release. This fix is for ldap to fix the problems in a ldap release . |
SergioBertolinSG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, fixes #177
b985830 to
ae7686a
Compare
PVince81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 code looks fine
fixes #177 if core does not do the sync