Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 24, 2025

Follow-on after #9968. These 2 types are TS-only, so none of the fields are optional. Correct TS type defs by replacing TSNull with Null etc in the extra field types.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Mar 24, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review March 24, 2025 07:35
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 24, 2025
Copy link
Member Author

overlookmotel commented Mar 24, 2025

Merge activity

  • Mar 24, 3:35 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 24, 3:40 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 24, 3:47 AM EDT: A user merged this pull request with the Graphite merge queue.

@overlookmotel
Copy link
Member Author

overlookmotel commented Mar 24, 2025

cc @therewillbecode @hi-ogawa FYI.

Note: It doesn't matter that this adds the extra fields in JS-only raw deserializer in deserialize-js.js, because those deserializer methods are dead code anyway in JS-only deserializer. I'll remove them entirely from the JS deserializer code at some point.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 24, 2025

CodSpeed Instrumentation Performance Report

Merging #10003 will not alter performance

Comparing 03-24-fix_ast_estree_fix_ts_type_defs_for_tsindexsignature_and_tsindexsignaturename_ (707a776) with main (c98d3f4)

Summary

✅ 33 untouched benchmarks

…SignatureName` (#10003)

Follow-on after #9968. These 2 types are TS-only, so none of the fields are optional. Correct TS type defs by replacing `TSNull` with `Null` etc in the extra field types.
@graphite-app graphite-app bot force-pushed the 03-24-fix_ast_estree_fix_ts_type_defs_for_tsindexsignature_and_tsindexsignaturename_ branch from 039c024 to 707a776 Compare March 24, 2025 07:41
@graphite-app graphite-app bot merged commit 707a776 into main Mar 24, 2025
27 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 24, 2025
@graphite-app graphite-app bot deleted the 03-24-fix_ast_estree_fix_ts_type_defs_for_tsindexsignature_and_tsindexsignaturename_ branch March 24, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants