Skip to content

Conversation

@therewillbecode
Copy link
Contributor

@therewillbecode therewillbecode commented Mar 22, 2025

Add missing estree fields to TSIndexSignature and TSIndexSignatureName

PR is part of ongoing work to align our AST's ESTree output with that of TS-ESLint's. Relates to #9705.

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 22, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Mar 22, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 22, 2025

CodSpeed Instrumentation Performance Report

Merging #9968 will not alter performance

Comparing therewillbecode:fix/TSIndexSignature (c19b0bf) with main (71dce1f)

Summary

✅ 33 untouched benchmarks

Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder when TSIndexSignature.accessibility becomes non null. Maybe something legacy and tseslint doens't use it? 🤔 https://github.com/typescript-eslint/typescript-eslint/blob/84744742c79cf3c1a81cbb08fd2cbaf75b45afc7/packages/ast-spec/src/element/TSIndexSignature/spec.ts#L9

Either way, I think we can proceed and revisit if we spot something different in the future. Thanks!

@hi-ogawa hi-ogawa added the 0-merge Merge with Graphite Merge Queue label Mar 23, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 23, 2025

Merge activity

  • Mar 23, 1:53 AM EDT: @therewillbecode we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 23, 2025
@hi-ogawa hi-ogawa merged commit 4980b73 into oxc-project:main Mar 23, 2025
24 checks passed
graphite-app bot pushed a commit that referenced this pull request Mar 24, 2025
…SignatureName` (#10003)

Follow-on after #9968. These 2 types are TS-only, so none of the fields are optional. Correct TS type defs by replacing `TSNull` with `Null` etc in the extra field types.
@therewillbecode therewillbecode deleted the fix/TSIndexSignature branch April 11, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants