-
-
Notifications
You must be signed in to change notification settings - Fork 758
fix(ast/estree): Add missing estree fields to TSIndexSignature and TSIndexSignatureName
#9968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ast/estree): Add missing estree fields to TSIndexSignature and TSIndexSignatureName
#9968
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Instrumentation Performance ReportMerging #9968 will not alter performanceComparing Summary
|
hi-ogawa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder when TSIndexSignature.accessibility becomes non null. Maybe something legacy and tseslint doens't use it? 🤔 https://github.com/typescript-eslint/typescript-eslint/blob/84744742c79cf3c1a81cbb08fd2cbaf75b45afc7/packages/ast-spec/src/element/TSIndexSignature/spec.ts#L9
Either way, I think we can proceed and revisit if we spot something different in the future. Thanks!
Merge activity
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link |
Add missing estree fields to TSIndexSignature and TSIndexSignatureName
PR is part of ongoing work to align our AST's ESTree output with that of TS-ESLint's. Relates to #9705.