Skip to content

refactor(ast_tools): move ident_name function to utils module #10024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Mar 25, 2025
Merged

refactor(ast_tools): move ident_name function to utils module #10024

graphite-app merged 1 commit into from
Mar 25, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 25, 2025 •
edited
Loading

Pure refactor. Move this utility function to utils module.

@github-actions github-actions bot added the A-ast-tools Area - AST tools label Mar 25, 2025
@overlookmotel overlookmotel mentioned this pull request Mar 25, 2025
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 25, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Mar 25, 2025
This was referenced Mar 25, 2025
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review March 25, 2025 03:54
@overlookmotel
Copy link
Member Author

overlookmotel commented Mar 25, 2025

Small refactor only, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 25, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 25, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 24, 11:59 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 25, 12:01 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 25, 4:08 AM UTC: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Mar 25, 12:26 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 25, 12:36 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 25, 12:43 AM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from 03-25-perf_ast_tools_reduce_string_allocations to graphite-base/10024 March 25, 2025 04:00
@graphite-app graphite-app bot changed the base branch from graphite-base/10024 to main March 25, 2025 04:06
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 25, 2025
@overlookmotel overlookmotel force-pushed the 03-25-refactor_ast_tools_move_ident_name_function_to_utils_module branch from 01563d0 to 324e443 Compare March 25, 2025 04:26
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 25, 2025
@overlookmotel
refactor(ast_tools): move ident_name function to utils module (#1…
196fc6a 
…0024)

Pure refactor. Move this utility function to `utils` module.
@graphite-app graphite-app bot force-pushed the 03-25-refactor_ast_tools_move_ident_name_function_to_utils_module branch from 324e443 to 196fc6a Compare March 25, 2025 04:36
@graphite-app graphite-app bot merged commit 196fc6a into main Mar 25, 2025
17 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 25, 2025
@graphite-app graphite-app bot deleted the 03-25-refactor_ast_tools_move_ident_name_function_to_utils_module branch March 25, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel