feat(ast_tools): better handling of formatting errors #10025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast-tools
Member
Author
|
Does not alter generated code, only improves behavior under error conditions. So merging without review. |
Member
Author
Merge activity
|
overlookmotel
force-pushed
the
03-25-refactor_ast_tools_move_ident_name_function_to_utils_module
branch
from
01563d0 to
324e443
Compare
overlookmotel
force-pushed
the
03-25-feat_ast_tools_better_handling_of_formatting_errors
branch
from
6059a86 to
9601dcc
Compare
Improve handling of parsing/formatting errors in outputs. Previously would panic or output an empty file, which made debugging what was causing the problem difficult. Instead output the unformatted source, so can look at it and figure out what's wrong.
graphite-app
bot
force-pushed
the
03-25-refactor_ast_tools_move_ident_name_function_to_utils_module
branch
from
324e443 to
196fc6a
Compare
graphite-app
bot
force-pushed
the
03-25-feat_ast_tools_better_handling_of_formatting_errors
branch
from
9601dcc to
68ee796
Compare
Base automatically changed from
03-25-refactor_ast_tools_move_ident_name_function_to_utils_module
to
main
March 25, 2025 04:43
graphite-app
bot
deleted the
03-25-feat_ast_tools_better_handling_of_formatting_errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve handling of parsing/formatting errors in outputs.
Previously would panic or output an empty file, which made debugging what was causing the problem difficult. Instead output the unformatted source, so can look at it and figure out what's wrong.