-
-
Notifications
You must be signed in to change notification settings - Fork 755
perf(codegen): faster printing quotes #10080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2025
Merged
Member
Author
CodSpeed Instrumentation Performance ReportMerging #10080 will not alter performanceComparing Summary
Benchmarks breakdown
|
Contributor
Merge activity
|
61beb43 to
e3a2d8a
Compare
699ade4 to
e44b613
Compare
e44b613 to
7bdf93b
Compare
e3a2d8a to
5cc0884
Compare
This was referenced Mar 28, 2025
7bdf93b to
16b3916
Compare
5cc0884 to
ce4b22b
Compare
16b3916 to
3511357
Compare
ce4b22b to
2e54383
Compare
This was referenced Mar 28, 2025
Avoid checks when printing quotes, by introducing a `Quote` enum which is statically known to be an ASCII character.
2e54383 to
719742b
Compare
3511357 to
d190466
Compare
Base automatically changed from
03-26-refactor_codegen_print_string_literals_containing_lone_surrogates_without_reference_to_raw_
to
main
March 29, 2025 13:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-codegen
Area - Code Generation
C-performance
Category - Solution not expected to change functional behavior, only performance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Avoid checks when printing quotes, by introducing a
Quoteenum which is statically known to be an ASCII character.