Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 27, 2025

Avoid checks when printing quotes, by introducing a Quote enum which is statically known to be an ASCII character.

Copy link
Member Author

overlookmotel commented Mar 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-codegen Area - Code Generation C-performance Category - Solution not expected to change functional behavior, only performance labels Mar 27, 2025
@overlookmotel overlookmotel marked this pull request as ready for review March 27, 2025 15:48
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 27, 2025

CodSpeed Instrumentation Performance Report

Merging #10080 will not alter performance

Comparing 03-27-perf_codegen_faster_printing_quotes (d190466) with 03-26-refactor_codegen_print_string_literals_containing_lone_surrogates_without_reference_to_raw_ (719742b)

Summary

✅ 30 untouched benchmarks
🆕 3 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 28, 2025

Merge activity

  • Mar 28, 4:37 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 29, 8:29 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Mar 29, 9:09 AM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 03-26-refactor_codegen_print_string_literals_containing_lone_surrogates_without_reference_to_raw_ branch from 61beb43 to e3a2d8a Compare March 28, 2025 05:09
@graphite-app graphite-app bot force-pushed the 03-27-perf_codegen_faster_printing_quotes branch from 699ade4 to e44b613 Compare March 28, 2025 05:09
@overlookmotel overlookmotel force-pushed the 03-27-perf_codegen_faster_printing_quotes branch from e44b613 to 7bdf93b Compare March 28, 2025 10:30
@overlookmotel overlookmotel force-pushed the 03-26-refactor_codegen_print_string_literals_containing_lone_surrogates_without_reference_to_raw_ branch from e3a2d8a to 5cc0884 Compare March 28, 2025 10:30
@overlookmotel overlookmotel force-pushed the 03-27-perf_codegen_faster_printing_quotes branch from 7bdf93b to 16b3916 Compare March 28, 2025 12:07
@overlookmotel overlookmotel force-pushed the 03-26-refactor_codegen_print_string_literals_containing_lone_surrogates_without_reference_to_raw_ branch from 5cc0884 to ce4b22b Compare March 28, 2025 12:07
@overlookmotel overlookmotel force-pushed the 03-27-perf_codegen_faster_printing_quotes branch from 16b3916 to 3511357 Compare March 28, 2025 12:59
@overlookmotel overlookmotel force-pushed the 03-26-refactor_codegen_print_string_literals_containing_lone_surrogates_without_reference_to_raw_ branch from ce4b22b to 2e54383 Compare March 28, 2025 12:59
Avoid checks when printing quotes, by introducing a `Quote` enum which is statically known to be an ASCII character.
@graphite-app graphite-app bot force-pushed the 03-26-refactor_codegen_print_string_literals_containing_lone_surrogates_without_reference_to_raw_ branch from 2e54383 to 719742b Compare March 29, 2025 12:49
@graphite-app graphite-app bot force-pushed the 03-27-perf_codegen_faster_printing_quotes branch from 3511357 to d190466 Compare March 29, 2025 12:49
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 29, 2025
Base automatically changed from 03-26-refactor_codegen_print_string_literals_containing_lone_surrogates_without_reference_to_raw_ to main March 29, 2025 13:06
@graphite-app graphite-app bot merged commit d190466 into main Mar 29, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 03-27-perf_codegen_faster_printing_quotes branch March 29, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants