Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 28, 2025

Add a benchmark for codegen with minify: true option.

Primarily this is to see what (if any) effect #10046 has on performance. We may want to remove it again later.

Copy link
Member Author

overlookmotel commented Mar 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review March 28, 2025 14:05
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 28, 2025

CodSpeed Instrumentation Performance Report

Merging #10109 will create unknown performance changes

Comparing 03-28-ci_codegen_add_benchmark_for_minified_printing (021986e) with main (9b6e344)

Summary

🆕 34 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.7 ms N/A
🆕 codegen_minify[checker.ts] N/A 18.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.7 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.2 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.4 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16 ms N/A
🆕 mangler[react.development.js] N/A 294.4 µs N/A
🆕 mangler[typescript.js] N/A 39.7 ms N/A
🆕 minifier[antd.js] N/A 165.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 291.6 ms N/A
🆕 estree[checker.ts] N/A 96.9 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 92.5 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@overlookmotel overlookmotel force-pushed the 03-28-ci_codegen_add_benchmark_for_minified_printing branch from b48f9c2 to 202f3c3 Compare March 28, 2025 14:43
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 29, 2025
Copy link
Member

Boshen commented Mar 29, 2025

Merge activity

  • Mar 29, 8:24 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 30, 1:47 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@graphite-app graphite-app bot changed the base branch from 03-28-fix_codegen_do_not_escape_in_strings_unless_using_backtick_as_quote to graphite-base/10109 March 29, 2025 12:50
@graphite-app graphite-app bot force-pushed the graphite-base/10109 branch from 87a539a to 9b6e344 Compare March 29, 2025 13:11
@graphite-app graphite-app bot force-pushed the 03-28-ci_codegen_add_benchmark_for_minified_printing branch from 202f3c3 to a898510 Compare March 29, 2025 13:11
@graphite-app graphite-app bot changed the base branch from graphite-base/10109 to main March 29, 2025 13:11
@graphite-app graphite-app bot force-pushed the 03-28-ci_codegen_add_benchmark_for_minified_printing branch from a898510 to 021986e Compare March 29, 2025 13:12
@Boshen Boshen added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Mar 30, 2025
@overlookmotel overlookmotel marked this pull request as draft March 31, 2025 09:12
@overlookmotel
Copy link
Member Author

We don't need this.

@Boshen Boshen deleted the 03-28-ci_codegen_add_benchmark_for_minified_printing branch August 30, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants