refactor(isolated_declarations): use FormalParameter::has_modifier to detect parameter properties
#10098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tect parameter properties
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-isolated-declarations
Dunqing
approved these changes
Mar 28, 2025
Dunqing
changed the title
FormalParameter::has_modifier to detect parameter propertiesFormalParameter::has_modifier to detect parameter properties
github-actions
bot
added
the
C-cleanup
CodSpeed Instrumentation Performance ReportMerging #10098 will not alter performanceComparing Summary
|
ulrichstark
deleted the
use-formalparameter-hasmodifier-in-isolated-declarations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using this function, the code is shorter and the missing check for the
overridemodifier is added.This PR is the result of splitting #10081 into smaller PRs.