Skip to content

Conversation

@ulrichstark
Copy link
Contributor

By using this function, the code is shorter and aligns with the changes of the original PR.

This PR is the result of splitting #10081 into smaller PRs.

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 28, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 28, 2025

CodSpeed Instrumentation Performance Report

Merging #10099 will not alter performance

Comparing ulrichstark:use-formalparameter-hasmodifier-in-transformer (62fdc74) with main (59b855f)

Summary

✅ 33 untouched benchmarks

@Dunqing
Copy link
Member

Dunqing commented Mar 28, 2025

BTW, I think this PR and #10097, and #10098 should merge into one because their purposes are the same, just for "shorten code by using FormalParameter::has_modifier". But anyway, maybe I am okay merging these PRs. Thank you for your work!

@Dunqing Dunqing merged commit 2720204 into oxc-project:main Mar 28, 2025
24 checks passed
@ulrichstark ulrichstark deleted the use-formalparameter-hasmodifier-in-transformer branch March 28, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants