Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 31, 2025

function a() {}; function a() {} and var a; function a() {} are still valid in script code, and should not be valid for module code. See https://tc39.github.io/ecma262/#sec-scripts-static-semantics-lexicallydeclarednames

Copy link
Member Author

Dunqing commented Mar 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-semantic Area - Semantic C-bug Category - Bug labels Mar 31, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 31, 2025

CodSpeed Instrumentation Performance Report

Merging #10148 will not alter performance

Comparing 03-31-fix_semantic_false_positive_checking_redeclaration_of_function_in_script_code (be08766) with main (11ddda6)

Summary

✅ 36 untouched benchmarks

@Dunqing Dunqing marked this pull request as ready for review March 31, 2025 09:14
@Dunqing Dunqing requested a review from Boshen as a code owner March 31, 2025 09:14
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 31, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 31, 2025

Merge activity

…cript code (#10148)

`function a() {}; function a() {}` and `var a; function a() {}` are still valid in script code, and should not be valid for module code. See https://tc39.github.io/ecma262/#sec-scripts-static-semantics-lexicallydeclarednames
@graphite-app graphite-app bot force-pushed the 03-31-fix_semantic_false_positive_checking_redeclaration_of_function_in_script_code branch from ce10e88 to be08766 Compare March 31, 2025 11:51
@graphite-app graphite-app bot merged commit be08766 into main Mar 31, 2025
28 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 31, 2025
@graphite-app graphite-app bot deleted the 03-31-fix_semantic_false_positive_checking_redeclaration_of_function_in_script_code branch March 31, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants