Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 31, 2025

The following code is invalid in both strict mode and non-strict mode.

for (let x; false; ) label1: label2: function f() {}

@Dunqing Dunqing requested a review from Boshen as a code owner March 31, 2025 09:13
@github-actions github-actions bot added A-semantic Area - Semantic C-bug Category - Bug labels Mar 31, 2025
Copy link
Member Author

Dunqing commented Mar 31, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 31, 2025

CodSpeed Instrumentation Performance Report

Merging #10149 will create unknown performance changes

Comparing 03-31-fix_semantic_function_declaration_is_not_allowed_in_labeledstatement (765ef4c) with main (be08766)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.6 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.6 ms N/A
🆕 formatter[antd.js] N/A 7.9 ms N/A
🆕 formatter[react.development.js] N/A 43.6 µs N/A
🆕 formatter[typescript.js] N/A 7.2 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.2 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16 ms N/A
🆕 mangler[react.development.js] N/A 296 µs N/A
🆕 mangler[typescript.js] N/A 39.7 ms N/A
🆕 minifier[antd.js] N/A 165.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 291.6 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 31, 2025
Copy link
Member

Boshen commented Mar 31, 2025

Merge activity

  • Mar 31, 7:51 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 31, 7:51 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Mar 31, 7:59 AM EDT: A user merged this pull request with the Graphite merge queue.

…nt` (#10149)

The following code is invalid in both strict mode and non-strict mode.
```js
for (let x; false; ) label1: label2: function f() {}
```
@graphite-app graphite-app bot force-pushed the 03-31-fix_semantic_false_positive_checking_redeclaration_of_function_in_script_code branch from ce10e88 to be08766 Compare March 31, 2025 11:51
@graphite-app graphite-app bot force-pushed the 03-31-fix_semantic_function_declaration_is_not_allowed_in_labeledstatement branch from 6fee2ed to 765ef4c Compare March 31, 2025 11:52
Base automatically changed from 03-31-fix_semantic_false_positive_checking_redeclaration_of_function_in_script_code to main March 31, 2025 11:57
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 31, 2025
@graphite-app graphite-app bot merged commit 765ef4c into main Mar 31, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 03-31-fix_semantic_function_declaration_is_not_allowed_in_labeledstatement branch March 31, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants