refactor(transformer/legacy-decorator): split the transforming decorated class into two parts and run them in exit_class and exit_statement respectively
#10153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
Dunqing
changed the title
exit_class and exit_statement respectively
CodSpeed Instrumentation Performance ReportMerging #10153 will degrade performances by 3.41%Comparing Summary
Benchmarks breakdown
|
Dunqing
force-pushed
the
04-01-refactor_transformer_legacy-decorator_split_the_transforming_decorated_class_into_two_parts_and_run_them_in_exit_class_and_exit_statement_respectively
branch
from
5512f31 to
413b69d
Compare
Contributor
Merge activity
|
…ted class into two parts and run them in `exit_class` and `exit_statement` respectively (#10153) close: #10147 Since `class-properties` will transform the class first, which causes the property will transform into `defineProperty(xxx)` and insert in the constructor. This results in the decorators being lost. This PR splits the logic into two parts, one part used to transform decorators in `exit_class`, which runs before class-properties transformation. The other part is to transform `class A {}` into `let A = class A {}` in `exit_statement`.
graphite-app
bot
force-pushed
the
03-31-test_transformer_legacy-decorator_enable_class-properties_plugin_for_class-related_tests
branch
from
1259d7e to
8c296f7
Compare
graphite-app
bot
force-pushed
the
04-01-refactor_transformer_legacy-decorator_split_the_transforming_decorated_class_into_two_parts_and_run_them_in_exit_class_and_exit_statement_respectively
branch
from
413b69d to
e4029b8
Compare
Base automatically changed from
03-31-test_transformer_legacy-decorator_enable_class-properties_plugin_for_class-related_tests
to
main
April 1, 2025 05:42
graphite-app
bot
deleted the
04-01-refactor_transformer_legacy-decorator_split_the_transforming_decorated_class_into_two_parts_and_run_them_in_exit_class_and_exit_statement_respectively
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #10147
Since
class-propertieswill transform the class first, which causes the property will transform intodefineProperty(xxx)and insert in the constructor. This results in the decorators being lost. This PR splits the logic into two parts, one part used to transform decorators inexit_class, which runs before class-properties transformation. The other part is to transformclass A {}intolet A = class A {}inexit_statement.