fix(transformer): TransformOptions::enable_all enable decorator transform

[overlookmotel]

No description provided.

[overlookmotel]

• fix(transformer): TransformOptions::enable_all enable decorator transform #9946 👈 (View in Graphite)
• fix(transformer/legacy-decorator): do not emit decorator metadata if the class is not decorated or it is typescript syntax #10154
• refactor(transformer/legacy-decorator): split the transforming decorated class into two parts and run them in exit_class and exit_statement respectively #10153
• test(transformer/legacy-decorator): enable class-properties plugin for class-related tests #10150
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #9946 will not alter performance

_{Comparing 03-21-fix_transformer_transformoptions_enable_all_enable_decorator_transform (e4ab61b) with 04-01-fix_transformer_legacy-decorator_do_not_emit_decorator_metadata_if_the_class_isn_t_decorated_or_it_is_typescript_syntax (44efec7)}

Summary

✅ 36 untouched benchmarks

[overlookmotel]

Oh dear!

[Dunqing]

Oh dear, I think we should turn off the legacy decorator plugin for conformance and monitor-oxc because we don't know where the decorator in code is es or the legacy decorator. Transform es decorator by legacy decorator plugin which might cause unexpected circumstances and vice versa.

[overlookmotel]

After #9952, conformance all passes (well at least doesn't panic!) with legacy: true.

But with emit_decorator_metadata: true there's a panic in this test case:

https://github.com/microsoft/TypeScript/blob/4dc677b292354f4b9162452b2e00f4d7dd118221/tests/cases/compiler/exportedInterfaceInaccessibleInCallbackInModule.ts

on this line:

oxc/crates/oxc_transformer/src/decorator/legacy/mod.rs

Line 402 in 114ac43

let old_class_symbol_id = old_class_symbol_id.expect("class always has a symbol id");

I assume this is due to #7278.

I think it'd be ideal to enable decorators transform on conformance, even if we don't on monitor_oxc (for the reasons you gave).

[Boshen]

Merge activity

• Apr 1, 1:30 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Apr 1, 1:30 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Apr 1, 1:44 AM EDT: A user merged this pull request with the Graphite merge queue.