Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 2, 2025

The move_xxxx method's mission is accomplished. Let's use the TakeIn trait instead. See more details in #9654 and #9969.

Copy link
Member Author

Dunqing commented Apr 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 2, 2025

CodSpeed Instrumentation Performance Report

Merging #10171 will create unknown performance changes

Comparing 04-02-feat_ast_remove_all_astbuilder_move_xxxx_methods (14ff99c) with main (c198578)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.1 ms N/A
🆕 formatter[antd.js] N/A 7.6 ms N/A
🆕 formatter[react.development.js] N/A 43.5 µs N/A
🆕 formatter[typescript.js] N/A 7.6 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.2 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.4 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A
🆕 mangler[antd.js] N/A 15.9 ms N/A
🆕 mangler[react.development.js] N/A 293.5 µs N/A
🆕 mangler[typescript.js] N/A 39.4 ms N/A
🆕 minifier[antd.js] N/A 166.3 ms N/A
🆕 minifier[react.development.js] N/A 1.9 ms N/A
🆕 minifier[typescript.js] N/A 293.3 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Dunqing Dunqing marked this pull request as ready for review April 2, 2025 06:34
@Dunqing Dunqing force-pushed the 04-02-feat_ast_remove_all_astbuilder_move_xxxx_methods branch from 033eb0a to 9a329bf Compare April 2, 2025 06:38
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 4, 2025
Copy link
Member

Boshen commented Apr 4, 2025

Merge activity

The `move_xxxx` method's mission is accomplished. Let's use the `TakeIn` trait instead. See more details in #9654 and #9969.
@graphite-app graphite-app bot force-pushed the 04-02-refactor_transformer_minifier_replace_astbuilder_move_xxxx_methods_with_takein_trait branch from 120b494 to bcdbd38 Compare April 4, 2025 07:55
@graphite-app graphite-app bot requested a review from overlookmotel as a code owner April 4, 2025 07:55
@graphite-app graphite-app bot force-pushed the 04-02-feat_ast_remove_all_astbuilder_move_xxxx_methods branch from 9a329bf to 14ff99c Compare April 4, 2025 07:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 4, 2025
Base automatically changed from 04-02-refactor_transformer_minifier_replace_astbuilder_move_xxxx_methods_with_takein_trait to main April 4, 2025 08:12
@graphite-app graphite-app bot merged commit 14ff99c into main Apr 4, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 04-02-feat_ast_remove_all_astbuilder_move_xxxx_methods branch April 4, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants