feat(allocator): add TakeIn::take_in_box method

[Dunqing]

This method aims to solve many cases that need to wrapped by Box, See rolldown/rolldown#4003 (comment)

[Dunqing]

• feat(ast)!: remove all AstBuilder::move_xxxx methods #10171
• refactor(transformer, minifier): replace AstBuilder::move_xxxx methods with TakeIn trait #10170
• feat(allocator): add TakeIn::take_in_box method #10169 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10169 will create unknown performance changes

_{Comparing 04-02-feat_allocator_add_takein_take_in_box_method (c198578) with main (a788a64)}

Summary

🆕 36 new benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
🆕	codegen[checker.ts]	N/A	22.1 ms	N/A
🆕	codegen_sourcemap[checker.ts]	N/A	65.1 ms	N/A
🆕	formatter[antd.js]	N/A	7.6 ms	N/A
🆕	formatter[react.development.js]	N/A	43.4 µs	N/A
🆕	formatter[typescript.js]	N/A	7.6 ms	N/A
🆕	isolated-declarations[vue-id.ts]	N/A	58.2 ms	N/A
🆕	lexer[RadixUIAdoptionSection.jsx]	N/A	21.4 µs	N/A
🆕	lexer[antd.js]	N/A	24.8 ms	N/A
🆕	lexer[cal.com.tsx]	N/A	5.9 ms	N/A
🆕	lexer[checker.ts]	N/A	14.8 ms	N/A
🆕	lexer[pdf.mjs]	N/A	3.9 ms	N/A
🆕	linter[RadixUIAdoptionSection.jsx]	N/A	2.7 ms	N/A
🆕	linter[cal.com.tsx]	N/A	1.2 s	N/A
🆕	linter[checker.ts]	N/A	3 s	N/A
🆕	mangler[antd.js]	N/A	15.9 ms	N/A
🆕	mangler[react.development.js]	N/A	292.9 µs	N/A
🆕	mangler[typescript.js]	N/A	39.4 ms	N/A
🆕	minifier[antd.js]	N/A	166.3 ms	N/A
🆕	minifier[react.development.js]	N/A	1.9 ms	N/A
🆕	minifier[typescript.js]	N/A	293.2 ms	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[graphite-app]

Merge activity

• Apr 4, 3:54 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Apr 4, 4:10 AM EDT: Merged by the Graphite merge queue.

[overlookmotel]

@Dunqing I'm not sure if this is ideal way to implement it. I think what this is doing is:

1. Construct dummy T on stack.
2. Pull original T onto stack.
3. Overwrite original T with dummy T in arena.
4. Allocate original T back into arena again -> Box<T>.

Whereas this would be preferable:

1. Construct dummy T on stack.
2. Allocate dummy into arena, creating a Box<T>.
3. Replace original Box<T> with dummy Box<T>.

The original T doesn't need to be pulled out of arena and than allocated back in again. Also, compiler may be smart enough to see it can construct the dummy directly in arena (combining steps 1 + 2), in which case it avoids large types on the stack entirely.

I should have thought about how to handle Box when I designed TakeIn. My bad.

Perhaps we should implement take_in_box on Box instead?

impl<'a, T: Dummy> for Box<'a, T> {
    fn take_in_box(&mut self, allocator: &'a Allocator) -> Self {
        let dummy = Box::new_in(T::dummy(allocator), allocator);
        mem::replace(self, dummy)
    }
}