Skip to content

Conversation

@therewillbecode
Copy link
Contributor

@therewillbecode therewillbecode commented Apr 3, 2025

Renames field from typeParameters to typeArguments field for the Estree serialiser on the TSInstantiationExpression node.

Part of our broader work to align our AST's ESTree output with that of TS-ESLint's. Relates to #9705

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 3, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Apr 3, 2025
@therewillbecode therewillbecode force-pushed the fix/ts-instantiation-expression branch from cf62161 to c35c3a1 Compare April 3, 2025 18:08
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 3, 2025

CodSpeed Instrumentation Performance Report

Merging #10206 will degrade performances by 3.2%

Comparing therewillbecode:fix/ts-instantiation-expression (c35c3a1) with main (52f2a40)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.9 ms 7.6 ms +3.84%
formatter[typescript.js] 7.2 ms 7.4 ms -3.2%

@overlookmotel
Copy link
Member

overlookmotel commented Apr 4, 2025

On this one, I think it'd be better to rename the field in the Rust type, to match what #9815 did for various other types.

pub struct TSInstantiationExpression<'a> {
    pub span: Span,
    pub expression: Expression<'a>,
-   pub type_parameters: Box<'a, TSTypeParameterInstantiation<'a>>,
+   pub type_arguments: Box<'a, TSTypeParameterInstantiation<'a>>,
}

@overlookmotel
Copy link
Member

Implemented in #10327.

@leaysgur
Copy link
Member

leaysgur commented Apr 9, 2025

Oh sorry! I didn't realize you were already working on... 🙇🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants