Skip to content

fix(parser)!: rename type_parameters to type_arguments where needed #9815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Mar 18, 2025
Merged

fix(parser)!: rename type_parameters to type_arguments where needed #9815

graphite-app merged 1 commit into from
Mar 18, 2025

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Mar 17, 2025 •
edited
Loading

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Mar 17, 2025
@hi-ogawa Graphite App
Copy link
Contributor Author

hi-ogawa commented Mar 17, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hi-ogawa hi-ogawa mentioned this pull request Mar 17, 2025
Merged
@hi-ogawa hi-ogawa changed the title fix(ast/estree): fix some fix(ast/estree): rename "parameters" to "arguments" Mar 17, 2025
@graphite-app graphite-app bot changed the base branch from 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint to graphite-base/9815 March 17, 2025 05:35
@hi-ogawa hi-ogawa mentioned this pull request Mar 17, 2025
Merged
@hi-ogawa hi-ogawa force-pushed the 03-17-fix_ast_estree_fix_some branch from 908ef9d to 2b63e25 Compare March 17, 2025 05:39
@hi-ogawa hi-ogawa force-pushed the graphite-base/9815 branch from e023355 to 8a3d097 Compare March 17, 2025 05:39
@hi-ogawa hi-ogawa changed the base branch from graphite-base/9815 to 03-17-test_ast_estree_update_acorn-test262 March 17, 2025 05:39
@hi-ogawa hi-ogawa force-pushed the 03-17-fix_ast_estree_fix_some branch from 2b63e25 to 0dc8040 Compare March 17, 2025 05:40
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 17, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9815 will not alter performance

Comparing 03-17-fix_ast_estree_fix_some (ce6808a) with main (e408db8)

Summary

✅ 33 untouched benchmarks

@hi-ogawa hi-ogawa force-pushed the 03-17-fix_ast_estree_fix_some branch from c41be09 to da17751 Compare March 17, 2025 05:46
Boshen
Boshen reviewed Mar 17, 2025
View reviewed changes
@hi-ogawa hi-ogawa force-pushed the 03-17-test_ast_estree_update_acorn-test262 branch from bd6b077 to eea59ed Compare March 17, 2025 05:48
@hi-ogawa hi-ogawa force-pushed the 03-17-fix_ast_estree_fix_some branch from c33ec55 to 108e501 Compare March 17, 2025 05:48
@graphite-app graphite-app bot changed the base branch from 03-17-test_ast_estree_update_acorn-test262 to graphite-base/9815 March 17, 2025 06:02
@graphite-app graphite-app bot force-pushed the 03-17-fix_ast_estree_fix_some branch from 108e501 to 813fdb6 Compare March 17, 2025 06:08
@graphite-app graphite-app bot force-pushed the graphite-base/9815 branch from eea59ed to 5f2d36b Compare March 17, 2025 06:08
@graphite-app graphite-app bot changed the base branch from graphite-base/9815 to main March 17, 2025 06:09
@graphite-app graphite-app bot force-pushed the 03-17-fix_ast_estree_fix_some branch from 813fdb6 to 6eaea53 Compare March 17, 2025 06:09
@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-prettier A-isolated-declarations Isolated Declarations labels Mar 17, 2025
@hi-ogawa hi-ogawa force-pushed the 03-17-fix_ast_estree_fix_some branch from 9d2dab5 to 80add05 Compare March 17, 2025 06:42
@hi-ogawa hi-ogawa changed the title fix(ast/estree): rename "parameters" to "arguments" fix(parser)!: rename type_parameters to type_arguments where needed Mar 17, 2025
@hi-ogawa hi-ogawa marked this pull request as ready for review March 17, 2025 06:54
@hi-ogawa hi-ogawa requested a review from Boshen March 17, 2025 06:54
This was referenced Mar 17, 2025
Merged
Merged
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 17, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Mar 17, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 17, 4:26 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 17, 4:26 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 17, 8:35 AM UTC: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Mar 17, 8:58 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 17, 9:09 PM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 17, 9:16 PM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 17, 2025
@overlookmotel
Copy link
Member

overlookmotel commented Mar 17, 2025

@hi-ogawa Merge conflict. Not sure where it came from.

@hi-ogawa hi-ogawa force-pushed the 03-17-fix_ast_estree_fix_some branch from 80add05 to 44b1b5a Compare March 18, 2025 00:57
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
@graphite-app graphite-app bot force-pushed the 03-17-fix_ast_estree_fix_some branch from 44b1b5a to ce6808a Compare March 18, 2025 01:09
@graphite-app graphite-app bot merged commit ce6808a into main Mar 18, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 03-17-fix_ast_estree_fix_some branch March 18, 2025 01:16
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
This was referenced Mar 18, 2025
Merged
Merged
This was referenced Mar 20, 2025
Merged
Merged
@ArnaudBarre
Copy link
Contributor

ArnaudBarre commented Mar 26, 2025

For info there is one left: TSInstantiationExpression

@overlookmotel overlookmotel mentioned this pull request Apr 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

@leaysgur leaysgur Awaiting requested review from leaysgur

@Boshen Boshen Awaiting requested review from Boshen

Assignees

No one assigned

Labels

A-ast Area - AST A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations A-linter Area - Linter A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hi-ogawa @Boshen @overlookmotel @ArnaudBarre