Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Apr 3, 2025

closes #10205

Copy link
Contributor Author

camc314 commented Apr 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 changed the base branch from c/03-22-fix_transfomer_using_remove_use_of_child_ids to graphite-base/10211 April 3, 2025 20:13
@camc314 camc314 changed the title fix(transformer): transform using declarations in try block fix(transformer/using): transform using declarations in try block Apr 3, 2025
@camc314 camc314 requested a review from Boshen April 3, 2025 20:14
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 3, 2025

CodSpeed Instrumentation Performance Report

Merging #10211 will degrade performances by 3.74%

Comparing c/04-03-fix_transformer_transform_using_declarations_in_try_block (778b044) with main (fba11d2)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.6 ms 7.9 ms -3.74%
formatter[typescript.js] 7.4 ms 7.2 ms +3.53%

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Apr 4, 2025
Copy link
Member

Dunqing commented Apr 4, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/04-03-fix_transformer_transform_using_declarations_in_try_block branch from ffc3de1 to 778b044 Compare April 4, 2025 01:05
@graphite-app graphite-app bot changed the base branch from graphite-base/10211 to c/03-22-fix_transfomer_using_remove_use_of_child_ids April 4, 2025 01:05
Base automatically changed from c/03-22-fix_transfomer_using_remove_use_of_child_ids to main April 4, 2025 01:12
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 4, 2025
@graphite-app graphite-app bot merged commit 778b044 into main Apr 4, 2025
30 checks passed
@graphite-app graphite-app bot deleted the c/04-03-fix_transformer_transform_using_declarations_in_try_block branch April 4, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explicit Resource Management syntax is not transformed in try .. catch block

3 participants