Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Mar 22, 2025

fixes #9744

@camc314 camc314 marked this pull request as ready for review March 22, 2025 00:08
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Mar 22, 2025
Copy link
Contributor Author

camc314 commented Mar 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 force-pushed the c/03-22-fix_transfomer_using_remove_use_of_child_ids branch from d70450f to fd4b0c7 Compare March 22, 2025 00:11
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 22, 2025

CodSpeed Instrumentation Performance Report

Merging #9961 will degrade performances by 3.74%

Comparing c/03-22-fix_transfomer_using_remove_use_of_child_ids (f48f895) with main (fba11d2)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.6 ms 7.9 ms -3.74%
formatter[typescript.js] 7.4 ms 7.2 ms +3.53%

@camc314 camc314 changed the base branch from c/03-22-fix_transformer_using_correctly_reparent_scopes_in_for_of_stmt to graphite-base/9961 March 22, 2025 00:33
@camc314 camc314 force-pushed the c/03-22-fix_transfomer_using_remove_use_of_child_ids branch from fd4b0c7 to 9391d23 Compare March 22, 2025 11:12
@camc314 camc314 requested a review from Boshen as a code owner March 22, 2025 11:12
@camc314 camc314 force-pushed the graphite-base/9961 branch from 088e6a4 to 20ec38e Compare March 22, 2025 11:12
@camc314 camc314 changed the base branch from graphite-base/9961 to c/03-22-fix_transformer_using_correctly_reparent_scopes_in_for_of_stmt March 22, 2025 11:12
@github-actions github-actions bot added the A-semantic Area - Semantic label Mar 22, 2025
@camc314 camc314 force-pushed the c/03-22-fix_transfomer_using_remove_use_of_child_ids branch from 9391d23 to 3cfc9f1 Compare March 22, 2025 11:15
@camc314 camc314 changed the base branch from c/03-22-fix_transformer_using_correctly_reparent_scopes_in_for_of_stmt to graphite-base/9961 March 22, 2025 11:16
@camc314 camc314 force-pushed the c/03-22-fix_transfomer_using_remove_use_of_child_ids branch from 3cfc9f1 to f76a83b Compare March 22, 2025 11:20
@camc314 camc314 changed the base branch from graphite-base/9961 to c/03-22-fix_transformer_using_correctly_reparent_scopes_in_for_of_stmt March 22, 2025 11:20
@camc314 camc314 force-pushed the c/03-22-fix_transfomer_using_remove_use_of_child_ids branch from f76a83b to 5973bbd Compare March 22, 2025 11:21
@camc314 camc314 force-pushed the c/03-22-fix_transformer_using_correctly_reparent_scopes_in_for_of_stmt branch from 20ec38e to 4c2e111 Compare March 22, 2025 11:21
@graphite-app graphite-app bot changed the base branch from c/03-22-fix_transformer_using_correctly_reparent_scopes_in_for_of_stmt to graphite-base/9961 March 24, 2025 11:41
@overlookmotel overlookmotel marked this pull request as draft March 24, 2025 11:46
@camc314 camc314 force-pushed the c/03-22-fix_transfomer_using_remove_use_of_child_ids branch from 5973bbd to 7dffe96 Compare March 24, 2025 12:28
@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-cli Area - CLI A-minifier Area - Minifier labels Mar 24, 2025
@camc314 camc314 removed A-linter Area - Linter A-parser Area - Parser A-cli Area - CLI A-minifier Area - Minifier A-ast Area - AST A-codegen Area - Code Generation A-cfg Area - Control Flow Graph A-isolated-declarations Isolated Declarations A-ast-tools Area - AST tools A-editor Area - Editor and Language Server labels Mar 24, 2025
@camc314 camc314 force-pushed the c/03-22-fix_transfomer_using_remove_use_of_child_ids branch from 34ddbd7 to 021f76c Compare March 24, 2025 13:07
@camc314 camc314 requested a review from overlookmotel March 27, 2025 14:39
@camc314 camc314 force-pushed the c/03-22-fix_transfomer_using_remove_use_of_child_ids branch from 021f76c to 1a9e4fe Compare March 30, 2025 12:36
@camc314
Copy link
Contributor Author

camc314 commented Mar 30, 2025

i think this should be ready to merge? let me know if there's anything missing.

@camc314 camc314 force-pushed the c/03-22-fix_transfomer_using_remove_use_of_child_ids branch from 1a9e4fe to 5e6c074 Compare April 3, 2025 19:52
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 4, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/03-22-fix_transfomer_using_remove_use_of_child_ids branch from 5e6c074 to f48f895 Compare April 4, 2025 01:04
@Dunqing
Copy link
Member

Dunqing commented Apr 4, 2025

I am merging this to unblock fixer from #10211, so without @overlookmotel further review.

@graphite-app graphite-app bot merged commit f48f895 into main Apr 4, 2025
30 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 4, 2025
@graphite-app graphite-app bot deleted the c/03-22-fix_transfomer_using_remove_use_of_child_ids branch April 4, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transformer: using crashes

4 participants