perf(minifier): reduce allocations #10301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-minifier
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
(prompted by looking where we're using |
CodSpeed Instrumentation Performance ReportMerging #10301 will degrade performances by 3.54%Comparing Summary
Benchmarks breakdown
|
Member
Merge activity
|
In these 3 places, we `pop` a statement from a `Vec` and insert it elsewhere. Previously we used `take_in_box` to get the statement first (which involves allocating a dummy node into arena) and then `pop`-ed and discarded the dummy. Instead do the `pop` first, to avoid the unnecessary allocation. I *assume* that compiler will see that the `unreachable!` path is genuinely unreachable because we just checked the type of the statement above, and will elide that check.
graphite-app
bot
force-pushed
the
04-07-perf_minifier_reduce_allocations
branch
from
192098d to
876b6ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these 3 places, we
popa statement from aVecand insert it elsewhere.Previously we used
take_in_boxto get the statement first (which involves allocating a dummy node into arena) and thenpop-ed and discarded the dummy. Instead do thepopfirst, to avoid the unnecessary allocation.I assume that compiler will see that the
unreachable!path is genuinely unreachable because we just checked the type of the statement above, and will elide that check.