refactor(ecmascript)!: remove PropertyReadSideEffects::OnlyMemberPropertyAccess
#13348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-minifier
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #13348 will not alter performanceComparing Summary
Footnotes |
IWANABETHATGUY
approved these changes
Aug 28, 2025
Contributor
|
https://deepwiki.com/search/what-is-the-difference-between_7a582090-34a7-4c97-a981-9bd6deeee882, here is the example deepwiki explained what is the difference between |
Contributor
Merge activity
|
…pertyAccess` (#13348) In #10129, I introduced `PropertyReadSideEffects`. In that, I added `PropertyReadSideEffects::OnlyMemberPropertyAccess`. This was because I thought this was the default behavior of Rollup at that time. But after re-reading the Rollup's code and checking the behavior in REPL while reviewing rolldown/rolldown#5945, I noticed that I was wrong. Since this was added solely for Rolldown to add support for `treeshake.propertyReadSideEffects` and it's not useful for that usecase, I removed the value. cc @IWANABETHATGUY
graphite-app
bot
force-pushed
the
08-28-refactor_ecmascript_remove_propertyreadsideeffects_onlymemberpropertyaccess_
branch
from
5f153fd to
e459866
Compare
graphite-app
bot
deleted the
08-28-refactor_ecmascript_remove_propertyreadsideeffects_onlymemberpropertyaccess_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10129, I introduced
PropertyReadSideEffects. In that, I addedPropertyReadSideEffects::OnlyMemberPropertyAccess. This was because I thought this was the default behavior of Rollup at that time.But after re-reading the Rollup's code and checking the behavior in REPL while reviewing rolldown/rolldown#5945, I noticed that I was wrong. Since this was added solely for Rolldown to add support for
treeshake.propertyReadSideEffectsand it's not useful for that usecase, I removed the value.cc @IWANABETHATGUY