Skip to content

feat(ecmascript): add property_read_side_effects to MayHaveSideEffectsContext #10129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Mar 31, 2025
Merged

feat(ecmascript): add property_read_side_effects to MayHaveSideEffectsContext #10129

graphite-app merged 1 commit into from
Mar 31, 2025

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Mar 30, 2025 •
edited
Loading

For treeshake.propertyReadSideEffects support.
Currently, PropertyReadSideEffects::OnlyMemberPropertyAccess and PropertyReadSideEffects::All works the same.

This was referenced Mar 30, 2025
Merged
Merged
@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Mar 30, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 30, 2025
Merged
Merged
@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Mar 30, 2025
@sapphi-red sapphi-red marked this pull request as ready for review March 30, 2025 10:45
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 30, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10129 will degrade performances by 3.31%

Comparing 03-30-feat_ecmascript_add_property_read_side_effects_to_mayhavesideeffectscontext_ (ef3451c) with main (962f3ba)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ formatter[antd.js] 7.9 ms 7.6 ms +3.89%
❌ formatter[typescript.js] 7.2 ms 7.4 ms -3.31%

sapphi-red
sapphi-red commented Mar 30, 2025
View reviewed changes
@sapphi-red sapphi-red force-pushed the 03-30-feat_ecmascript_add_is_pure_call_to_mayhavesideeffectscontext_ branch from 0a2f7c0 to d54867d Compare March 30, 2025 10:49
@sapphi-red sapphi-red force-pushed the 03-30-feat_ecmascript_add_property_read_side_effects_to_mayhavesideeffectscontext_ branch from 2c586f7 to ce73ad3 Compare March 30, 2025 10:49
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 30, 2025
@graphite-app graphite-app bot changed the base branch from 03-30-feat_ecmascript_add_is_pure_call_to_mayhavesideeffectscontext_ to graphite-base/10129 March 30, 2025 11:55
@graphite-app graphite-app bot force-pushed the 03-30-feat_ecmascript_add_property_read_side_effects_to_mayhavesideeffectscontext_ branch from ce73ad3 to 45c3045 Compare March 30, 2025 12:05
@graphite-app graphite-app bot force-pushed the graphite-base/10129 branch from d54867d to ac2ecbb Compare March 30, 2025 12:05
@graphite-app graphite-app bot changed the base branch from graphite-base/10129 to main March 30, 2025 12:06
@graphite-app graphite-app bot force-pushed the 03-30-feat_ecmascript_add_property_read_side_effects_to_mayhavesideeffectscontext_ branch from 45c3045 to b0e1322 Compare March 30, 2025 12:06
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 31, 2025 •
edited
Loading

Merge activity

@sapphi-red
feat(ecmascript): add property_read_side_effects to `MayHaveSideEff…
ef3451c 
…ectsContext` (#10129)

For [`treeshake.propertyReadSideEffects`](https://rollupjs.org/configuration-options/#treeshake-propertyreadsideeffects) support.
Currently, `PropertyReadSideEffects::OnlyMemberPropertyAccess` and `PropertyReadSideEffects::All` works the same.
@graphite-app graphite-app bot force-pushed the 03-30-feat_ecmascript_add_property_read_side_effects_to_mayhavesideeffectscontext_ branch from b0e1322 to ef3451c Compare March 31, 2025 07:26
@graphite-app graphite-app bot merged commit ef3451c into main Mar 31, 2025
28 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 31, 2025
@graphite-app graphite-app bot deleted the 03-30-feat_ecmascript_add_property_read_side_effects_to_mayhavesideeffectscontext_ branch March 31, 2025 07:32
@oxc-bot oxc-bot mentioned this pull request Apr 1, 2025
Merged
@sapphi-red sapphi-red mentioned this pull request Aug 28, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Aug 28, 2025
@sapphi-red
refactor(ecmascript)!: remove `PropertyReadSideEffects::OnlyMemberPro…
e459866 
…pertyAccess` (#13348)

In #10129, I introduced `PropertyReadSideEffects`. In that, I added `PropertyReadSideEffects::OnlyMemberPropertyAccess`. This was because I thought this was the default behavior of Rollup at that time.

But after re-reading the Rollup's code and checking the behavior in REPL while reviewing rolldown/rolldown#5945, I noticed that I was wrong. Since this was added solely for Rolldown to add support for `treeshake.propertyReadSideEffects` and it's not useful for that usecase, I removed the value.

cc @IWANABETHATGUY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red