feat(napi)!: standardize function naming with sync suffixes #15661

Boshen · 2025-11-13T06:54:53Z

closes #15576

Summary

Standardizes function naming across all NAPI packages (parser, transform, minify) with a consistent pattern:

Async functions: verb (no suffix)
Sync functions: verbSync (with Sync suffix)

Changes

Breaking Changes

napi/parser:

parseAsync → parse (async)
parseSync remains unchanged (sync)

napi/transform:

transformAsync → transform (async)
transform → transformSync (sync)
isolatedDeclaration → isolatedDeclarationSync (sync)
Added new isolatedDeclaration function (async)
moduleRunnerTransform → moduleRunnerTransformSync (sync)
Added new moduleRunnerTransform function (async)

napi/minify:

minify → minifySync (sync)
Added new minify function (async)

🤖 Generated with Claude Code

graphite-app · 2025-11-13T06:55:02Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

Copilot

Pull Request Overview

This PR standardizes the naming convention for synchronous and asynchronous functions across all NAPI packages (parser, transform, minify), establishing a consistent pattern where async functions use the base verb name and sync functions use a Sync suffix.

Key Changes

Renamed async functions: parseAsync → parse, transformAsync → transform, and introduced new async minify, isolatedDeclaration, and moduleRunnerTransform functions
Renamed sync functions: transform → transformSync, minify → minifySync, isolatedDeclaration → isolatedDeclarationSync, moduleRunnerTransform → moduleRunnerTransformSync
Enhanced documentation: Added comprehensive API documentation to all README files with clear function signatures and usage guidance

Reviewed Changes

Copilot reviewed 29 out of 33 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
napi/transform/src/transformer.rs	Refactored to extract shared logic into `transform_impl` and `module_runner_transform_impl`; renamed functions to follow new convention
napi/transform/src/isolated_declaration.rs	Refactored to extract shared logic into `isolated_declaration_impl`; added async variant
napi/transform/test/*.ts	Updated all test files to use new function names; simplified async tests to verify equivalence with sync
napi/transform/*.js	Updated all exports to include both sync and async function variants
napi/parser/src/lib.rs	Renamed `parse_async` to `parse`; refactored to use `parse_impl`
napi/parser/src/raw_transfer.rs	Renamed `parse_async_raw` to `parse_raw`
napi/parser/src-js/*.js	Updated parser exports and raw transfer implementations to use new naming
napi/parser/test/*.ts	Updated all parser tests to use `parse` instead of `parseAsync`
napi/minify/src/lib.rs	Refactored to extract shared logic into `minify_impl`; added async variant
napi/minify/test/*.ts	Updated all minify tests to use new function names
napi/minify/*.js	Updated all exports to include both sync and async function variants
napi/*/README.md	Added comprehensive API documentation with function signatures and usage guidance
napi/*/index.d.ts	Updated TypeScript definitions to reflect new function names and return types
napi/playground/index.d.ts	Added new properties to `OxcSortImportsOptions` (unrelated to main PR purpose)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

napi/parser/src-js/bindings.js

napi/transform/test/transform.test.ts

napi/transform/src/transformer.rs

napi/parser/bench.bench.js

Boshen · 2025-11-13T12:27:36Z

Merge activity

Nov 13, 12:27 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 13, 12:27 PM UTC: Boshen added this pull request to the Graphite merge queue.
Nov 13, 12:33 PM UTC: Merged by the Graphite merge queue.

closes #15576 ## Summary Standardizes function naming across all NAPI packages (parser, transform, minify) with a consistent pattern: - Async functions: `verb` (no suffix) - Sync functions: `verbSync` (with Sync suffix) ## Changes ### Breaking Changes **napi/parser:** - `parseAsync` → `parse` (async) - `parseSync` remains unchanged (sync) **napi/transform:** - `transformAsync` → `transform` (async) - `transform` → `transformSync` (sync) - `isolatedDeclaration` → `isolatedDeclarationSync` (sync) - Added new `isolatedDeclaration` function (async) - `moduleRunnerTransform` → `moduleRunnerTransformSync` (sync) - Added new `moduleRunnerTransform` function (async) **napi/minify:** - `minify` → `minifySync` (sync) - Added new `minify` function (async) 🤖 Generated with [Claude Code](https://claude.com/claude-code)

ref: - oxc-project/oxc#15576 - oxc-project/oxc#15661

### 💥 BREAKING CHANGES - ea51b0b napi: [**BREAKING**] Standardize function naming with sync suffixes (#15661) (Boshen) ### 🚀 Features - 77efb76 parser: Improve error message for invalid switch clauses (#15728) (sapphi-red) - 5691727 parser: Improve `import source` `from` error message (#15727) (sapphi-red) - b7404bc parser: Improve error message for missing function body (#15726) (sapphi-red) - 71c2fb0 parser: Improve error message when JSX is found while not enabled (#15725) (sapphi-red) - 56e7e44 minifier: Disable removal of unnecessary `use strict` directives for DCE (#15691) (sapphi-red) - 8a61cfd allocator, ast: Introduce `UnstableAddress` trait (#15700) (overlookmotel) - f5ce55a napi: Export all options using wildcard exports (Boshen) - 68703b9 minifier: Rotate binary expressions to remove parentheses (#15473) (sapphi-red) ### 🐛 Bug Fixes - c023ba6 semantic: Do not duplicate statements in temp `Vec` when binding `TSModuleDeclaration`s (#15724) (overlookmotel) - d60ca81 parser: Reject `import something 'source'` (#15746) (sapphi-red) - e0728fa ast: Exclude comment end position from `is_inside_comment` check (#15753) (camc314) - 9f54a36 semantic: Error on `\00` in strict mode (#15743) (sapphi-red) - 440a977 ast: Include rest properties when using `get_binding_identifiers` (#15710) (camc314) ### ⚡ Performance - 1f09d3c parser: Faster checking for invalid modifiers (#15717) (overlookmotel) - d8d4e31 ast: Use loop instead of recursion in `TSModuleDeclarationBody::as_module_block_mut` (#15713) (overlookmotel) ### 📚 Documentation - e033d50 ast: Clarify behavior of `TSModuleDeclaration::has_use_strict_directive` (#15730) (overlookmotel) - 9eda70f allocator: Improve docs for `Address` methods (#15697) (overlookmotel)

ref: - oxc-project/oxc#15576 - oxc-project/oxc#15661

### 💥 BREAKING CHANGES - ea51b0b napi: [**BREAKING**] Standardize function naming with sync suffixes (oxc-project#15661) (Boshen) ### 🚀 Features - 77efb76 parser: Improve error message for invalid switch clauses (oxc-project#15728) (sapphi-red) - 5691727 parser: Improve `import source` `from` error message (oxc-project#15727) (sapphi-red) - b7404bc parser: Improve error message for missing function body (oxc-project#15726) (sapphi-red) - 71c2fb0 parser: Improve error message when JSX is found while not enabled (oxc-project#15725) (sapphi-red) - 56e7e44 minifier: Disable removal of unnecessary `use strict` directives for DCE (oxc-project#15691) (sapphi-red) - 8a61cfd allocator, ast: Introduce `UnstableAddress` trait (oxc-project#15700) (overlookmotel) - f5ce55a napi: Export all options using wildcard exports (Boshen) - 68703b9 minifier: Rotate binary expressions to remove parentheses (oxc-project#15473) (sapphi-red) ### 🐛 Bug Fixes - c023ba6 semantic: Do not duplicate statements in temp `Vec` when binding `TSModuleDeclaration`s (oxc-project#15724) (overlookmotel) - d60ca81 parser: Reject `import something 'source'` (oxc-project#15746) (sapphi-red) - e0728fa ast: Exclude comment end position from `is_inside_comment` check (oxc-project#15753) (camc314) - 9f54a36 semantic: Error on `\00` in strict mode (oxc-project#15743) (sapphi-red) - 440a977 ast: Include rest properties when using `get_binding_identifiers` (oxc-project#15710) (camc314) ### ⚡ Performance - 1f09d3c parser: Faster checking for invalid modifiers (oxc-project#15717) (overlookmotel) - d8d4e31 ast: Use loop instead of recursion in `TSModuleDeclarationBody::as_module_block_mut` (oxc-project#15713) (overlookmotel) ### 📚 Documentation - e033d50 ast: Clarify behavior of `TSModuleDeclaration::has_use_strict_directive` (oxc-project#15730) (overlookmotel) - 9eda70f allocator: Improve docs for `Address` methods (oxc-project#15697) (overlookmotel)

Copilot AI review requested due to automatic review settings November 13, 2025 06:54

github-actions bot added A-parser Area - Parser A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Nov 13, 2025

Copilot started reviewing on behalf of Boshen November 13, 2025 06:55 View session

Boshen requested a review from sapphi-red November 13, 2025 06:55

Boshen self-assigned this Nov 13, 2025

Copilot finished reviewing on behalf of Boshen November 13, 2025 06:57

Copilot AI reviewed Nov 13, 2025

View reviewed changes

napi/parser/src-js/bindings.js Outdated Show resolved Hide resolved

napi/transform/test/transform.test.ts Outdated Show resolved Hide resolved

Boshen force-pushed the feat/napi-consistent-naming branch 3 times, most recently from cd459e7 to d86e3de Compare November 13, 2025 07:24

sapphi-red reviewed Nov 13, 2025

View reviewed changes

napi/transform/src/transformer.rs Show resolved Hide resolved

Boshen force-pushed the feat/napi-consistent-naming branch 2 times, most recently from 9f3c8eb to 8eac59c Compare November 13, 2025 08:42

graphite-app bot reviewed Nov 13, 2025

View reviewed changes

napi/parser/bench.bench.js Show resolved Hide resolved

Boshen force-pushed the feat/napi-consistent-naming branch 3 times, most recently from 4b812c7 to c0a268e Compare November 13, 2025 12:10

Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 13, 2025

Boshen changed the title ~~feat(napi)!: standardize function naming with async/sync suffixes~~ feat(napi)!: standardize function naming with sync suffixes Nov 13, 2025

graphite-app bot force-pushed the feat/napi-consistent-naming branch from c0a268e to ea51b0b Compare November 13, 2025 12:28

graphite-app bot merged commit ea51b0b into main Nov 13, 2025
18 checks passed

graphite-app bot deleted the feat/napi-consistent-naming branch November 13, 2025 12:33

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 13, 2025

sapphi-red mentioned this pull request Nov 14, 2025

feat: add await before async functions oxc-project/oxc-project.github.io#628

Merged

camc314 added a commit to camc314/rolldown that referenced this pull request Nov 15, 2025

fix: patch rolldown-plugin-dts due to changed exports

b337f0b

ref: - oxc-project/oxc#15576 - oxc-project/oxc#15661

camc314 added a commit to camc314/rolldown that referenced this pull request Nov 15, 2025

fix: patch rolldown-plugin-dts due to changed exports

f677d2f

ref: - oxc-project/oxc#15576 - oxc-project/oxc#15661

Boshen mentioned this pull request Nov 17, 2025

release(crates): oxc v0.98.0 #15771

Merged

camc314 added a commit to camc314/rolldown that referenced this pull request Nov 17, 2025

fix: patch rolldown-plugin-dts due to changed exports

de69ec8

ref: - oxc-project/oxc#15576 - oxc-project/oxc#15661

camc314 added a commit to camc314/rolldown that referenced this pull request Nov 17, 2025

fix: patch rolldown-plugin-dts due to changed exports

94e8898

ref: - oxc-project/oxc#15576 - oxc-project/oxc#15661

camc314 added a commit to camc314/rolldown that referenced this pull request Nov 17, 2025

fix: patch rolldown-plugin-dts due to changed exports

6347af3

ref: - oxc-project/oxc#15576 - oxc-project/oxc#15661

camc314 added a commit to camc314/rolldown that referenced this pull request Nov 17, 2025

fix: patch rolldown-plugin-dts due to changed exports

fdfc6ff

ref: - oxc-project/oxc#15576 - oxc-project/oxc#15661

takejohn mentioned this pull request Nov 17, 2025

Build failure with [email protected]: parseAsync no longer exported unplugin/unplugin-isolated-decl#74

Closed

5 tasks

Boshen pushed a commit to camc314/rolldown that referenced this pull request Nov 17, 2025

fix: patch rolldown-plugin-dts due to changed exports

cd68dea

ref: - oxc-project/oxc#15576 - oxc-project/oxc#15661

github-actions bot mentioned this pull request Dec 3, 2025

chore(deps): update dependency oxc-transform to v0.108.0 koki-develop/ghats#142

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(napi)!: standardize function naming with sync suffixes #15661

feat(napi)!: standardize function naming with sync suffixes #15661

Uh oh!

Boshen commented Nov 13, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Nov 13, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Boshen commented Nov 13, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat(napi)!: standardize function naming with sync suffixes #15661

feat(napi)!: standardize function naming with sync suffixes #15661

Uh oh!

Conversation

Boshen commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Breaking Changes

Uh oh!

graphite-app bot commented Nov 13, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Boshen commented Nov 13, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Boshen commented Nov 13, 2025 •

edited

Loading

Boshen commented Nov 13, 2025 •

edited by graphite-app bot

Loading