Conversation
Member
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
CodSpeed Performance ReportMerging #2114 will not alter performanceComparing Summary
|
Boshen
reviewed
Jan 22, 2024
Member
It's weird for the user. |
…ion and add binder for FormalParameter
Dunqing
force-pushed
the
01-22-refactor_semantic_splitting_the_FormalParameters_binder_implementation_and_add_binder_for_FormalParameter
branch
from
5fc8081 to
4a60946
Compare
Dunqing
changed the title
Boshen
deleted the
01-22-refactor_semantic_splitting_the_FormalParameters_binder_implementation_and_add_binder_for_FormalParameter
branch
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this pull request
May 29, 2024
…replacing the binder for FormalParameters (oxc-project#2114) Similar with oxc-project#2013. This way we will be able to find the corresponding Ast accurately. The snapshots look a little strange but the change is expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar with #2013.
This way we will be able to find the corresponding Ast accurately.
The snapshots look a little strange but the change is expected.