Skip to content

refactor(ast): rename RestElement to BindingRestElement#2116

Merged
Boshen merged 1 commit intomainfrom
01-22-chore_ast_rename_RestElement_to_BindingRestElement
Jan 22, 2024
Merged

refactor(ast): rename RestElement to BindingRestElement#2116
Boshen merged 1 commit intomainfrom
01-22-chore_ast_rename_RestElement_to_BindingRestElement

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 22, 2024 •
edited
Loading

close: #2115

@github-actions github-actions bot added the A-linter Area - Linter label Jan 22, 2024
@Dunqing
Copy link
Member Author

Dunqing commented Jan 22, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic A-ast Area - AST A-codegen Area - Code Generation A-prettier labels Jan 22, 2024
@Dunqing Dunqing mentioned this pull request Jan 22, 2024
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 22, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2116 will not alter performance

Comparing 01-22-chore_ast_rename_RestElement_to_BindingRestElement (2470b59) with main (8bccdab)

Summary

✅ 17 untouched benchmarks

@Boshen Boshen changed the title chore(ast): rename RestElement to BindingRestElement refactor(ast): rename RestElement to BindingRestElement Jan 22, 2024
@Boshen Graphite App
Copy link
Member

Boshen commented Jan 22, 2024 •
edited
Loading

Merge activity

  • Jan 22, 1:23 AM: @Boshen started a stack merge that includes this pull request via Graphite.
  • Jan 22, 1:24 AM: Graphite rebased this pull request as part of a merge.
  • Jan 22, 1:28 AM: @Boshen merged this pull request with Graphite.

Base automatically changed from 01-22-refactor_semantic_splitting_the_FormalParameters_binder_implementation_and_add_binder_for_FormalParameter to main January 22, 2024 06:23
@Boshen Boshen force-pushed the 01-22-chore_ast_rename_RestElement_to_BindingRestElement branch from b3d19ad to 2470b59 Compare January 22, 2024 06:23
@Boshen Boshen merged commit 766ca63 into main Jan 22, 2024
@Boshen Boshen deleted the 01-22-chore_ast_rename_RestElement_to_BindingRestElement branch January 22, 2024 06:28
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@Dunqing @IWANABETHATGUY
refactor(ast): rename RestElement to BindingRestElement (oxc-project#…
49ddc35 
…2116)

close: oxc-project#2115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-ast Area - AST A-codegen Area - Code Generation A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(ast): rename RestElement to BindingRestElement

2 participants

@Dunqing @Boshen