chore(semantic): copy tests from typescript-eslint’s scope-manager

[Dunqing]

close: #2947

These fixtures were copied from https://github.com/typescript-eslint/typescript-eslint/tree/a5b652da1ebb09ecbca8f4b032bf05ebc0e03dc9/packages/scope-manager/tests/fixtures. We used them to test out semantic ScopeTree and SymbolTable

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[Dunqing]

• fix(semantic): incorrect resolve references for TSInterfaceHeritage #4311
• fix(semantic): incorrect resolve references for TSTypeQuery #4310
• chore(semantic): copy tests from typescript-eslint’s scope-manager #3990 👈
• fix(semantic): resolve references to the incorrect symbol #4280
• feat(ast): align ts ast scope with typescript #4253
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #3990 will not alter performance

_{Comparing 07-01-chore_semantic_copy_tests_from_typescript-eslint_s_scope-manager (48724a0) with main (1f8968a)}

Summary

✅ 32 untouched benchmarks

[Dunqing]

It's kind of weird that the fields in my local and CI's snap are in a different order. So, I had to tweak the order of the different fields in push_str to make CI pass.

[overlookmotel]

This would be a pain in the short term, but maybe save us time overall by avoiding having to check all these snapshots by hand:

Could we parse the snapshots from typescript-eslint repo (example) and check them against our own scopes tree? The format is not the same, but it's mostly the same info.

[Dunqing]

Could we parse the snapshots from typescript-eslint repo (example) and check them against our own scopes tree? The format is not the same, but it's mostly the same info.

I gave it a try, it’s hard to parse to JSON

[graphite-app]

Merge activity

• Jul 16, 10:49 PM EDT: Boshen added this pull request to the Graphite merge queue.
• Jul 16, 10:57 PM EDT: Boshen merged this pull request with the Graphite merge queue.