Skip to content

chore(semantic): copy tests from typescript-eslint’s scope-manager #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jul 17, 2024
Merged

chore(semantic): copy tests from typescript-eslint’s scope-manager #3990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/oxc_semantic/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ indexmap = { workspace = true }
insta = { workspace = true, features = ["glob"] }
phf = { workspace = true, features = ["macros"] }
rustc-hash = { workspace = true }
serde_json = { workspace = true }

[features]
default = []
Expand Down
8 changes: 4 additions & 4 deletions crates/oxc_semantic/src/reference.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@ impl Reference {
self.symbol_id = Some(symbol_id);
}

pub fn flag_mut(&mut self) -> &mut ReferenceFlag {
&mut self.flag
}

pub fn flag(&self) -> &ReferenceFlag {
&self.flag
}

pub fn flag_mut(&mut self) -> &mut ReferenceFlag {
&mut self.flag
}

/// Returns `true` if the identifier value was read. This is not mutually
/// exclusive with [`#is_write`]
pub fn is_read(&self) -> bool {
Expand Down
1 change: 1 addition & 0 deletions crates/oxc_semantic/tests/fixtures/typescript-eslint/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
These fixtures were copied from https://github.com/typescript-eslint/typescript-eslint/tree/a5b652da1ebb09ecbca8f4b032bf05ebc0e03dc9/packages/scope-manager/tests/fixtures. We used them to test out semantic [ScopeTree](../../src/scope.rs) and [SymbolTable](../../src/symbol.rs)
36 changes: 36 additions & 0 deletions crates/oxc_semantic/tests/fixtures/typescript-eslint/block/inherited-scope.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
source: crates/oxc_semantic/tests/main.rs
input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/block/inherited-scope.ts
---
[
{
"children": [
{
"children": [],
"flag": "ScopeFlags(StrictMode)",
"id": 1,
"node": "BlockStatement",
"symbols": []
}
],
"flag": "ScopeFlags(StrictMode | Top)",
"id": 0,
"node": "Program",
"symbols": [
{
"flag": "SymbolFlags(BlockScopedVariable | ConstVariable)",
"id": 0,
"name": "a",
"node": "VariableDeclarator",
"references": [
{
"flag": "ReferenceFlag(Read)",
"id": 0,
"name": "a",
"node_id": 7
}
]
}
]
}
]
5 changes: 5 additions & 0 deletions crates/oxc_semantic/tests/fixtures/typescript-eslint/block/inherited-scope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
const a = 1;

{
a;
}
43 changes: 43 additions & 0 deletions crates/oxc_semantic/tests/fixtures/typescript-eslint/block/scope.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
---
source: crates/oxc_semantic/tests/main.rs
input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/block/scope.ts
---
[
{
"children": [
{
"children": [],
"flag": "ScopeFlags(StrictMode)",
"id": 1,
"node": "BlockStatement",
"symbols": [
{
"flag": "SymbolFlags(BlockScopedVariable)",
"id": 0,
"name": "i",
"node": "VariableDeclarator",
"references": [
{
"flag": "ReferenceFlag(Read)",
"id": 0,
"name": "i",
"node_id": 11
}
]
},
{
"flag": "SymbolFlags(BlockScopedVariable)",
"id": 1,
"name": "j",
"node": "VariableDeclarator",
"references": []
}
]
}
],
"flag": "ScopeFlags(StrictMode | Top)",
"id": 0,
"node": "Program",
"symbols": []
}
]
7 changes: 7 additions & 0 deletions crates/oxc_semantic/tests/fixtures/typescript-eslint/block/scope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
let i = 20;
let j = 1;
i;
}

j;
62 changes: 62 additions & 0 deletions crates/oxc_semantic/tests/fixtures/typescript-eslint/call-expression/call-expression.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
---
source: crates/oxc_semantic/tests/main.rs
input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/call-expression/call-expression.ts
---
[
{
"children": [
{
"children": [],
"flag": "ScopeFlags(StrictMode | Function | Arrow)",
"id": 1,
"node": "ArrowFunctionExpression",
"symbols": []
}
],
"flag": "ScopeFlags(StrictMode | Top)",
"id": 0,
"node": "Program",
"symbols": [
{
"flag": "SymbolFlags(BlockScopedVariable | ConstVariable)",
"id": 0,
"name": "foo",
"node": "VariableDeclarator",
"references": [
{
"flag": "ReferenceFlag(Read)",
"id": 0,
"name": "foo",
"node_id": 15
},
{
"flag": "ReferenceFlag(Read)",
"id": 1,
"name": "foo",
"node_id": 21
}
]
},
{
"flag": "SymbolFlags(BlockScopedVariable | ConstVariable)",
"id": 1,
"name": "a",
"node": "VariableDeclarator",
"references": [
{
"flag": "ReferenceFlag(Read)",
"id": 0,
"name": "a",
"node_id": 14
},
{
"flag": "ReferenceFlag(Read)",
"id": 1,
"name": "a",
"node_id": 20
}
]
}
]
}
]
5 changes: 5 additions & 0 deletions crates/oxc_semantic/tests/fixtures/typescript-eslint/call-expression/call-expression.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
const foo = () => {};
const a = 1;

foo(a);
foo?.(a);
36 changes: 36 additions & 0 deletions crates/oxc_semantic/tests/fixtures/typescript-eslint/call-expression/type-parameters1.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
source: crates/oxc_semantic/tests/main.rs
input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/call-expression/type-parameters1.ts
---
[
{
"children": [
{
"children": [],
"flag": "ScopeFlags(StrictMode)",
"id": 1,
"node": "TSTypeAliasDeclaration",
"symbols": []
}
],
"flag": "ScopeFlags(StrictMode | Top)",
"id": 0,
"node": "Program",
"symbols": [
{
"flag": "SymbolFlags(TypeAlias)",
"id": 0,
"name": "T",
"node": "TSTypeAliasDeclaration",
"references": [
{
"flag": "ReferenceFlag(Type)",
"id": 0,
"name": "T",
"node_id": 11
}
]
}
]
}
]
2 changes: 2 additions & 0 deletions crates/oxc_semantic/tests/fixtures/typescript-eslint/call-expression/type-parameters1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
type T = 1;
foo<T>();
21 changes: 21 additions & 0 deletions crates/oxc_semantic/tests/fixtures/typescript-eslint/call-expression/type-parameters2.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
---
source: crates/oxc_semantic/tests/main.rs
input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/call-expression/type-parameters2.ts
---
[
{
"children": [],
"flag": "ScopeFlags(StrictMode | Top)",
"id": 0,
"node": "Program",
"symbols": [
{
"flag": "SymbolFlags(BlockScopedVariable | ConstVariable)",
"id": 0,
"name": "T",
"node": "VariableDeclarator",
"references": []
}
]
}
]
2 changes: 2 additions & 0 deletions crates/oxc_semantic/tests/fixtures/typescript-eslint/call-expression/type-parameters2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
const T = 1;
foo<T>(); // should not resolve to value
67 changes: 67 additions & 0 deletions crates/oxc_semantic/tests/fixtures/typescript-eslint/catch/inherited-scope.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
---
source: crates/oxc_semantic/tests/main.rs
input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/catch/inherited-scope.ts
---
[
{
"children": [
{
"children": [],
"flag": "ScopeFlags(StrictMode)",
"id": 1,
"node": "BlockStatement",
"symbols": []
},
{
"children": [
{
"children": [],
"flag": "ScopeFlags(StrictMode)",
"id": 3,
"node": "BlockStatement",
"symbols": [
{
"flag": "SymbolFlags(FunctionScopedVariable | CatchVariable)",
"id": 1,
"name": "e",
"node": "CatchParameter",
"references": []
}
]
}
],
"flag": "ScopeFlags(StrictMode | CatchClause)",
"id": 2,
"node": "CatchClause",
"symbols": [
{
"flag": "SymbolFlags(FunctionScopedVariable | CatchVariable)",
"id": 1,
"name": "e",
"node": "CatchParameter",
"references": []
}
]
}
],
"flag": "ScopeFlags(StrictMode | Top)",
"id": 0,
"node": "Program",
"symbols": [
{
"flag": "SymbolFlags(BlockScopedVariable | ConstVariable)",
"id": 0,
"name": "a",
"node": "VariableDeclarator",
"references": [
{
"flag": "ReferenceFlag(Read)",
"id": 0,
"name": "a",
"node_id": 12
}
]
}
]
}
]
5 changes: 5 additions & 0 deletions crates/oxc_semantic/tests/fixtures/typescript-eslint/catch/inherited-scope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
const a = 1;
try {
} catch (e) {
a;
}
Loading