Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Feb 26, 2025

No description provided.

Copy link
Member Author

Dunqing commented Feb 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 26, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #9401 will not alter performance

Comparing 02-26-refactor_transformer_construct_string_by_ctx.ast.atom_from_array (adf7987) with main (48fa01c)

Summary

✅ 39 untouched benchmarks

@Dunqing Dunqing force-pushed the 02-26-refactor_transformer_construct_string_by_ctx.ast.atom_from_array branch from 2c1350d to 786b71e Compare March 6, 2025 09:53
@Dunqing Dunqing force-pushed the 02-26-feat_ast_add_astbuilder_atom_from_array branch from 2caf374 to 727afeb Compare March 6, 2025 09:53
@Dunqing Dunqing force-pushed the 02-26-refactor_transformer_construct_string_by_ctx.ast.atom_from_array branch 2 times, most recently from fbe827a to 7e9cfa4 Compare March 6, 2025 11:44
@Dunqing Dunqing force-pushed the 02-26-feat_ast_add_astbuilder_atom_from_array branch from 9f5e5a3 to 8913ded Compare March 6, 2025 12:55
@Dunqing Dunqing force-pushed the 02-26-refactor_transformer_construct_string_by_ctx.ast.atom_from_array branch from 7e9cfa4 to 62bd010 Compare March 6, 2025 12:55
@Dunqing Dunqing marked this pull request as ready for review March 6, 2025 12:56
@Dunqing Dunqing requested a review from overlookmotel as a code owner March 6, 2025 12:56
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 7, 2025
Copy link
Member

Boshen commented Mar 7, 2025

Merge activity

  • Mar 6, 10:15 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 7, 3:15 AM UTC: A user added this pull request to the Graphite merge queue.
  • Mar 7, 3:16 AM UTC: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Mar 7, 4:30 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 7, 4:39 AM EST: A user added this pull request to the Graphite merge queue.
  • Mar 7, 4:51 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 7, 2025
@graphite-app graphite-app bot force-pushed the 02-26-feat_ast_add_astbuilder_atom_from_array branch from 8913ded to 8ad0781 Compare March 7, 2025 03:16
@Dunqing Dunqing force-pushed the 02-26-feat_ast_add_astbuilder_atom_from_array branch from 8ad0781 to 9c2a370 Compare March 7, 2025 09:29
@Dunqing Dunqing force-pushed the 02-26-refactor_transformer_construct_string_by_ctx.ast.atom_from_array branch from 62bd010 to 52ce681 Compare March 7, 2025 09:29
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Mar 7, 2025
Base automatically changed from 02-26-feat_ast_add_astbuilder_atom_from_array to main March 7, 2025 09:35
@graphite-app graphite-app bot force-pushed the 02-26-refactor_transformer_construct_string_by_ctx.ast.atom_from_array branch from 52ce681 to adf7987 Compare March 7, 2025 09:39
@graphite-app graphite-app bot merged commit adf7987 into main Mar 7, 2025
32 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 7, 2025
@graphite-app graphite-app bot deleted the 02-26-refactor_transformer_construct_string_by_ctx.ast.atom_from_array branch March 7, 2025 09:51
@oxc-bot oxc-bot mentioned this pull request Mar 7, 2025
Boshen added a commit that referenced this pull request Mar 7, 2025
## [0.56.4] - 2025-03-07

### Bug Fixes

- c08b7fc napi: Commit wasi files (Boshen)
- 35626a4 npm: Change to `wasm32-wasip1-threads` target (Boshen)

### Refactor

- 62bffed rust: Allow a few annoying clippy rules (#9588) (Boshen)
- adf7987 transformer: Combine strings by `ctx.ast.atom_from_array`
(#9401) (Dunqing)

Co-authored-by: Boshen <[email protected]>
graphite-app bot pushed a commit that referenced this pull request Mar 11, 2025
#9686)

Follow-on after #9401. Use `itoa` to convert `u32` to string. It's more optimized for this task than `CompactString`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants