perf(transformer/module_runner): use itoa to convert u32 to string
#9686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-performance
CodSpeed Performance ReportMerging #9686 will not alter performanceComparing Summary
|
Dunqing
approved these changes
Mar 11, 2025
Member
Dunqing
left a comment
Dunqing
left a comment
There was a problem hiding this comment.
Looks great, BTW we don't have a benchmark for ModuleRunnerTransform as it isn't included in the main transformer
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
03-11-perf_transformer_module_runner_use_itoa_to_convert_u32_to_string
branch
from
9448d2a to
31d626b
Compare
graphite-app
bot
deleted the
03-11-perf_transformer_module_runner_use_itoa_to_convert_u32_to_string
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on after #9401. Use
itoato convertu32to string. It's more optimized for this task thanCompactString.